docs: remove unnecessary -- from pnpm test examples#313
Merged
james-elicx merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
commit: |
|
Collaborator
Author
|
/bonk review |
Contributor
There was a problem hiding this comment.
Correct fix. pnpm forwards positional args directly to the underlying script, so -- is unnecessary. The test script is vitest run, so pnpm test tests/routing.test.ts correctly becomes vitest run tests/routing.test.ts.
The alignment cleanup is a nice touch too — makes the comment column consistent.
Contributor
|
Approved the PR. The change is straightforward and correct — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm forwards flags and positional args directly to scripts, so
--is not needed and was silently running the full suite instead of the targeted file.