This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Conversation
|
What does this change have to do with the selection color? |
Contributor
Author
|
Those selectors have styling changes applied for autocomplete dropdown, making it look like the rest of bootstrap flatly themed elements. There's no less or scss in https://github.com/bootstrap-tagsinput/bootstrap-tagsinput/tree/master/src that could read of flatly variables file. |
Contributor
Author
|
Classes are controlled by typeahead, not by tagsinpt, so I need to follow https://github.com/corejavascript/typeahead.js/blob/master/doc/jquery_typeahead.md#class-names and configure proper classes here. |
We use flatly theme for bootstrap while bootstrap-tagsinput bundles a css file that follow vanilla style, create a less version and use it instead of the css one bundles with bootstrap-tagsinput. typeahead.js allows to customize class names used for UI elements, but bootstrap-tagsinput doesn't support passing that and is no longer maintained, so we need to follow default typeahead.js classes.
Contributor
Author
|
Reworked to use a less style file that imports from bootstrap, see commit for details. |
bobrik
approved these changes
Aug 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selector is too wide and doesn't action, add
divto make it work again.