Controlled encoding switch#315
Merged
Merged
Conversation
3b0fc21 to
5ec2a26
Compare
orium
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriter can now inform
OutputSinkwhat encoding is being used. Without that, theOutputSinkhad no way of correctly handling varying character encodings other than reparsing HTML itself.Directly using interior-mutable
SharedEncodingmade it harder to reason about currently used encoding. With encoding change being an explicit step, a simplerAsciiCompatibleEncodingcan be used in more places.I've also replaced
ALL_ENCODINGSlookup table withOnceLock. The encoding can be changed only once, so we can storeAsciiCompatibleEncodingdirectly without going throughAtomicUsize.