Add support for loading trace context from jaeger formatted strings#528
Merged
mitch292 merged 2 commits intocloudflare:masterfrom Oct 8, 2025
Merged
Conversation
mitch292
approved these changes
Sep 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 48.75% 45.90% -2.86%
==========================================
Files 25 28 +3
Lines 3222 3662 +440
==========================================
+ Hits 1571 1681 +110
- Misses 1477 1810 +333
+ Partials 174 171 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is trying to solve an issue of wire protocol compatibility with the keynotto implementation. That service is expecting to load trace state using the Jaeger text format. This is causing friction with clients which are interacting with both gokeyless and keynotto. Automatically supporting both in the gokeyless service will make it easier for clients to start propagating traces to both services without needing to consider the expected format.
While clients (or keynotto) could implement the binary format, it seems better to avoid continued use of a deprecated format in new code and instead allow the usage of the more convenient and widely support Jaeger text format.
Many clients are already propagating traces with the text format and I believe adding support here would result in the smallest amount of work overall.