Skip to content

Import deterministic ECDSA key generation code from Go 1.18 crypto/ecdsa package#63

Merged
ignatk merged 1 commit intocloudflare:mainfrom
zhsj:go1.20
Apr 18, 2023
Merged

Import deterministic ECDSA key generation code from Go 1.18 crypto/ecdsa package#63
ignatk merged 1 commit intocloudflare:mainfrom
zhsj:go1.20

Conversation

@zhsj
Copy link
Contributor

@zhsj zhsj commented Feb 8, 2023

Closes: #61

testGetKeyType(X25519, t)
testGetKeyType(ED25519, t)
for _, kt := range []KeyType{
EC384,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing EC256 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed

@ignatk
Copy link
Contributor

ignatk commented Feb 14, 2023

Hey, sorry for the delay on this. Due to some internal misconfig I lost the owner rights to this repository, so I can't run the CI or merge here. Once I restore them, I will action this PR. Thank you for the contribution!

@ignatk ignatk merged commit 51044cf into cloudflare:main Apr 18, 2023
@ignatk
Copy link
Contributor

ignatk commented Apr 18, 2023

Many thanks. Sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go1.20 TestGetKey: keys with same invocation options do not match

2 participants