WIP: reduce build time#28970
Closed
MohamedH1998 wants to merge 3 commits intocloudflare:productionfrom
Closed
Conversation
Contributor
Author
|
Resolved via: withastro/starlight#3761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Title: Optimize build: patch Starlight sidebar cloning (-14%)
Starlight deep-clones the full sidebar tree for every page (7,303x). Our
Page.astrooverride replacesprops.sidebarentirely, making this pure waste. Patching it out saves ~50s per build.Changes:
patches/@astrojs+starlight+0.37.6.patch— skipstructuredClone+setIntermediateSidebarCurrentEntryingetSidebarFromIntermediateSidebarsrc/util/sidebar.ts— hoistflattenSidebar()out of O(n^2) loopsrc/util/components.ts— scan-once caching for MDX file parsingsrc/util/glossary.ts— collection caching with Map lookup, preserves original behaviorBenchmarks (cold builds):
For a detailed walkthrough and breakdown, read: investigation summary
Screenshots (optional)
Documentation checklist