Skip to content

add assertion helper for extension keys#920

Merged
lionelvillard merged 4 commits intocloudevents:mainfrom
yanmxa:br_assert
Jul 17, 2023
Merged

add assertion helper for extension keys#920
lionelvillard merged 4 commits intocloudevents:mainfrom
yanmxa:br_assert

Conversation

@yanmxa
Copy link
Copy Markdown
Contributor

@yanmxa yanmxa commented Jul 14, 2023

resolved: #900

@yanmxa yanmxa force-pushed the br_assert branch 2 times, most recently from 81e4db0 to 91d4c02 Compare July 14, 2023 08:55
Signed-off-by: myan <myan@redhat.com>
yanmxa added 2 commits July 14, 2023 09:05
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
}
}

// HasExtensionKeys checks if the event contain the provided keys from its extensions
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit "contains"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@embano1 Done~

Signed-off-by: myan <myan@redhat.com>
Copy link
Copy Markdown
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Copy Markdown
Contributor

duglin commented Jul 17, 2023

LGTM

ping @lionelvillard for the merge

@lionelvillard lionelvillard merged commit e15d03d into cloudevents:main Jul 17, 2023
@yanmxa yanmxa deleted the br_assert branch July 18, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test.HasExtensionsKeys assertion helper

4 participants