Conversation
|
/cc @duglin |
|
@yanmxa thanks. Quick scan looks nice - will review more... ping @lionelvillard and @embano1 for their review too. |
|
Thanks, @embano1! I modified the test code and doc according to your view. Please feel free to contact me if you have found other issues~ |
|
Overall looking good @yanmxa We just need some more tests, especially around attribute/extension handling (verification) and writing messages. |
|
Looks good @yanmxa , just one final minor nit |
e17eed4 to
bb1e980
Compare
|
@embano1 Thank you very much for checking the code so carefully, which allows me to avoid similar problems in the future. |
No worries, that's my duty here ;) You're doing great work! Just try to keep the code simple and clean - your future self (and other contributors) will appreciate it ;) |
|
@embano1 Thanks! It was a little complicated about the integration tests with reference to other tests before, I do think too little about simplifying the test. But it should be better now compared to before. |
embano1
left a comment
There was a problem hiding this comment.
Approving, just one minor nit if you feel it's worth the change
Signed-off-by: myan <myan@redhat.com> add protocol and sample files Signed-off-by: myan <myan@redhat.com> rollback samples to go1.17 Signed-off-by: myan <myan@redhat.com> move the protocol to go1.17 Signed-off-by: myan <myan@redhat.com> add message test Signed-off-by: myan <myan@redhat.com> trigger to run the integration test Signed-off-by: myan <myan@redhat.com> fixed go mod issue Signed-off-by: myan <myan@redhat.com> resolve the review issue Signed-off-by: myan <myan@redhat.com> remove the useless comment Signed-off-by: myan <myan@redhat.com> add ut for writeMessage Signed-off-by: myan <myan@redhat.com> go mod tidy Signed-off-by: myan <myan@redhat.com> add intergration test Signed-off-by: myan <myan@redhat.com> solve the uncheck error Signed-off-by: myan <myan@redhat.com> fix the integration error Signed-off-by: myan <myan@redhat.com> fix the integration error Signed-off-by: myan <myan@redhat.com> reply the review Signed-off-by: myan <myan@redhat.com> simpler tests Signed-off-by: myan <myan@redhat.com> remove the nesting Signed-off-by: myan <myan@redhat.com> refactor the recevier logic Signed-off-by: myan <myan@redhat.com> add a timer for assert loop Signed-off-by: myan <myan@redhat.com>
| @@ -0,0 +1,114 @@ | |||
| package mqtt_paho | |||
There was a problem hiding this comment.
can you add the copyright?
|
Overall it looks good, though I'm not an MQTT expert so there is so much I can review. Please add the copyright header to all files and then I think we can merge this PR. |
Signed-off-by: myan <myan@redhat.com>
|
looks good. @duglin, ok with you? |
|
@embano1 approved it |
|
sorry - been busy - I trust you guys :-) |
Initial implementation of MQTT binding, using https://github.com/eclipse/paho.golang which supports MQTT V5
Note: This is just a basic implementation; some new features which are brought by MQTT 5.0 and other enhancements will be done in future PRs.
resolved: #901