fix: Fixing syntax errors and add some test feedback#892
Merged
lionelvillard merged 2 commits intocloudevents:mainfrom May 5, 2023
pr-fork:fix
Merged
fix: Fixing syntax errors and add some test feedback#892lionelvillard merged 2 commits intocloudevents:mainfrom pr-fork:fix
lionelvillard merged 2 commits intocloudevents:mainfrom
pr-fork:fix
Conversation
Contributor
|
can you please sign your commits? |
Contributor
Author
This?
|
Signed-off-by: Flc゛ <four_leaf_clover@foxmail.com>
Contributor
|
yes but you'll need to do it for all commits. It might be easier to squash it down to one commit and then just sign that one. |
Contributor
Author
|
Okay, that now? |
Contributor
|
yup - thanks |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.