Propagate informations from inbound messages up to Client#659
Merged
n3wscott merged 3 commits intocloudevents:masterfrom Jan 27, 2021
Merged
Propagate informations from inbound messages up to Client#659n3wscott merged 3 commits intocloudevents:masterfrom
n3wscott merged 3 commits intocloudevents:masterfrom
Conversation
…om the ObservabilityService Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
Author
Contributor
|
For this to be useful towards #658, we'd also need a way to add custom decorators to Perhaps a new option? // it may also be useful to type the decorator signature to make it easier to read
type ContextDecorator func(context.Context) context.Context
func WithInboundContextDecorators(decorators ...ContextDecorator) Option {
return func(i interface{}) error {
if c, ok := i.(*ceClient); ok {
c.inboundContextDecorators = append(c.inboundContextDecorators, decorators...)
}
return nil
}
} |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Member
Author
|
@dan-j Added a new option |
Contributor
|
LGTM |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now MessageContext is not replaced anymore (like done in #634) but it can be used together with a context decorator function.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com