Add flag enable_api_key_uid_reporting and report unknown when the check response status is not OK. #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
response status is not OK. Verified in local unit testing.
| @@ -0,0 +1,16 @@ | |||
| # GRPC Python setup requirements | |||
Contributor
There was a problem hiding this comment.
How do we keep this up to date now?
Collaborator
Author
There was a problem hiding this comment.
Up to date requirements might require Python later versions which is incompatible with ESP build rules.
Currently it's pinned to a specific version which could not update. How do you think we should address this?
Contributor
There was a problem hiding this comment.
I don't know. I think we have no choice to postpone the tech debts to later. Can you please log a TODO bug? File one in bugnizer so we can ask for resources based on these data points.
Collaborator
Author
There was a problem hiding this comment.
Sure, created todo and internal bug b/341556079.
| "apikey:api_key_x"); | ||
| } | ||
|
|
||
| TEST_F(ProtoTest, CredentailIdApiKeyUidTest) { |
Contributor
There was a problem hiding this comment.
Nit: typo "credential"?
shuoyang2016
approved these changes
May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified in local unit testing.