Increase timeout of fetching access token from metadata server to 5s #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
nareddyt
previously approved these changes
May 20, 2020
Contributor
|
Is it confirmed in the bug that 5s is enough time? @qiwzhang |
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
TAOXUY
approved these changes
May 20, 2020
Contributor
Author
|
@nareddyt Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Zhang qiwzhang@google.com
b/148454048: GKE metadata server needs > 2s to fetch access token.
Increase ESP access token fetching timeout to 5s (from 1s).