Skip to content

Conversation

@bnordli
Copy link

@bnordli bnordli commented May 15, 2020

Fixes #795.

(Pair programming with @oyvindwe. He has the build environment, so he will verify compilation and tests later.)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@qiwzhang
Copy link
Contributor

qiwzhang commented May 15, 2020

Test failure is due to code format

Files not formatted: src/grpc/zero_copy_stream_test.cc
Code style check failed.

whch is enforced by this script
script/robot-style

@qiwzhang
Copy link
Contributor

@bnordli if you don't mind, I can take over your change, and use a separate to submit it.

@bnordli
Copy link
Author

bnordli commented May 15, 2020

That's fine with me, @qiwzhang, and probably much quicker too! Thanks :)

(I didn't have a build environment and just tried to follow the general formatting.)

We requested a CLA for my company today, but it seems like I committed with my personal email. Hopefully everything should be alright using nordli@exabel.com.

@bnordli
Copy link
Author

bnordli commented May 15, 2020

No, the commit has the correct email. Let's check if my boss signed the CLA.

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gRPC transcoder may truncate response data for unknown proto fields

3 participants