Support nested openstack VM accessability#2403
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Apr 2, 2026
Merged
Support nested openstack VM accessability#2403cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cross-MCI and cross-namespace bastion support to improve VM accessibility (notably for OpenStack/private-network cases) by allowing a bastion VM to be selected from outside the target VM’s MCI/namespace and adapting tunneling behavior accordingly.
Changes:
- Added new REST routes/handlers to set a bastion using
(bastionMciId, bastionVmId)or(bastionNsId, bastionMciId, bastionVmId). - Extended
model.BastionNodeto includensId, and updated bastion-aware SSH execution to resolve bastion namespace and prefer target public IP for cross-bastion tunnels. - Updated Swagger artifacts and adjusted bastion auto-assignment call sites to the new
SetBastionNodessignature.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/interface/rest/server/server.go | Registers additional PUT endpoints for cross-MCI / cross-namespace bastion assignment. |
| src/interface/rest/server/infra/remoteCommand.go | Implements new REST handlers and updates existing handler to the new infra API signature. |
| src/interface/rest/docs/swagger.yaml | Documents the new endpoints and updates model.BastionNode schema. |
| src/interface/rest/docs/docs.go | Generated Swagger doc template updates for the new endpoints/schema. |
| src/core/model/vnet.go | Adds NsId to BastionNode to support cross-namespace bastions. |
| src/core/infra/remoteCommand.go | Core logic updates for cross-bastion SSH (namespace resolution + public-IP preference) and expanded SetBastionNodes API. |
| src/core/infra/provisioning.go | Updates bastion auto-assignment call to new SetBastionNodes signature. |
| assets/cloudinfo.yaml | Minor formatting/indentation adjustment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(bastionMciId, bastionVmId)or(bastionNsId, bastionMciId, bastionVmId).model.BastionNodeto includensId, and updated bastion-aware SSH execution to resolve bastion namespace and prefer target public IP for cross-bastion tunnels.SetBastionNodessignature.