@seokho-son

Since changing the credential format, registering IBM and GCP credentials fails during make init. Are you experiencing any issues?

Let me check. :)

Both OpenBao and CB-SP credentials for IBM/GCP works for me.

Registering credentials on OpenBao is working well for me as well. But.. registering those on Spider failed with GCP: Incomplete credential data, Skip.

I left the S3-related keys blank; would that be an issue?

yes it might be an issue I guess.

why don't you/we commented the keys with empty value in the credentials.yaml ?

I’m currently performing batch tests (Create, Get, and Delete) for VPNs on aws-to-tencent and aws-to-azure.

After the test, I will try your comment :)

In the meantime, I have two questions:

1. (minor) Lowercasing the header

I've changed X-Credential-Holder to x-credential-holder to stay consistent with Tumblebug API docs. HTTP headers are not case-sensitive, so this does not affect functionality. Is it okay to proceed as is?

2. Context Propagation

I've applied context propagation throughout GlobalDNS and VPN (from the Tumblebug API user input to the Terrarium API call). It appears to me that many other APIs do not yet use this pattern, so I would appreciate it if you could review whether this approach aligns with what you explained offline.

The test has passed. I'm switching the PR status to 'Ready for review'.

t many other APIs do not yet use this pattern, so I would appreciate it if you could review whether this approach aligns with what you explained offline.

@yunkon-kim could you let me know many other APIs do not yet use this pattern ? I've applied it to (most) required api handlers and core functionalities that requires calls to CSP with credentials (connections)

It appeared that the context was not being passed to the core function in about 5 handlers checked randomly. :)
(Including GlobalDns, VPN)

For example, I imagined the following parameter passing by the offline discussion.

// @Failure 500 {object} model.SimpleMsg
// @Router /resources/globalDns/hostedZone [get]
func RestGetHostedZones(c echo.Context) error {
	log.Debug().Msg("[DNS-REST] GET /resources/globalDns/hostedZone called")

	resp, err := resource.ListHostedZones(c.Request().Context()) <<<==== Passing context like this
	if err != nil {
		log.Error().Err(err).Msg("[DNS-REST] ListHostedZones failed")
		return c.JSON(classifyDnsError(err), model.SimpleMsg{Message: err.Error()})
	}

	log.Debug().Int("count", len(resp.HostedZones)).Msg("[DNS-REST] ListHostedZones succeeded")
	return c.JSON(http.StatusOK, resp)
}

@yunkon-kim
Oh,
For GlobalDns and VPN, I didn’t apply the context because those APIs did not support CredentialHolder at the time.

I expected this PR to add the context to all relevant APIs for GlobalDns and VPN. :)

/approve