Add Global DNS with Geoproximity strategy#2387
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Mar 29, 2026
Merged
Add Global DNS with Geoproximity strategy#2387cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Global DNS management enhancements (AWS Route53-backed) including geoproximity routing support and expanded REST endpoints, along with updated API docs (Swagger + feature guide).
Changes:
- Add Route53 geoproximity routing support for Global DNS record upserts (location-aware VM grouping).
- Add REST APIs for deleting single records, bulk deleting records, and listing hosted zones.
- Update Swagger/OpenAPI artifacts and add a new feature guide for Global DNS.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/interface/rest/server/server.go | Registers new Global DNS endpoints (delete, bulk delete, hosted zone list). |
| src/interface/rest/server/resource/globalDns.go | Adds REST handlers, logging, and HTTP error classification for Global DNS APIs. |
| src/core/resource/globalDns.go | Implements geoproximity upsert logic, delete/bulk-delete operations, hosted zone listing, and refactors Route53 client creation. |
| src/core/model/globalDns.go | Extends request/response models for routingPolicy, delete/bulk-delete, and hosted zone listing. |
| src/interface/rest/docs/swagger.yaml | Adds/updates OpenAPI paths and schemas for new Global DNS APIs and fields. |
| src/interface/rest/docs/docs.go | Regenerates embedded Swagger docs for the new endpoints/schemas. |
| docs/feature_guide/global-dns-management.md | New end-user guide describing Global DNS usage, routing policies, and examples. |
| docs/feature_guide/README.md | Links the new Global DNS feature guide. |
| go.mod / go.sum / go.work.sum | Dependency updates (AWS SDK, OpenBao API, etc.) required by new functionality. |
Comments suppressed due to low confidence (1)
src/core/resource/globalDns.go:222
- The recordName filter is documented as "Prefix search", but the implementation uses
strings.Contains(rs.Name, recordName), which can match unintended records (substring matches) and makes results unpredictable. Consider using a prefix match on the fully-qualified record name (including trailing dot) or an exact match when recordName is provided.
for _, rs := range out.ResourceRecordSets {
if recordName != "" && !strings.Contains(aws.ToString(rs.Name), recordName) {
continue
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides Create / Update DNS Record (UPSERT)
with a new Routing Policy: Geoproximity (nearest server)
with label selector enhancement.