Adjust sleep time just after termination#2386
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Mar 28, 2026
Merged
Adjust sleep time just after termination#2386cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tweaks timing behavior around VM/MCI termination and adjusts CB-Spider control request timeouts to better accommodate slower operations.
Changes:
- Reduced post-terminate sleep delays in
DelMciandDelMciVm(5s→1s, 2s→1s) and updated the corresponding log messages. - Increased the HTTP client timeout used by
ControlVmAsync(10m→20m; NCP override 15m→25m).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/core/infra/manageInfo.go |
Shortens fixed waits after triggering termination before proceeding with delete flows. |
src/core/infra/control.go |
Extends Spider control API request timeouts (general + NCP-specific). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.