Enhance code alignment for template feature#2353
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Mar 10, 2026
Merged
Enhance code alignment for template feature#2353cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates template-related documentation and template update behavior to better align with the “configCopy + template” workflow, plus some formatting/sample-template cleanup.
Changes:
- Refines Swagger annotations and generated OpenAPI artifacts for the MCI config copy endpoint to mention template creation behavior.
- Makes template
Nameeffectively immutable on update (MCI dynamic / vNet / securityGroup) and removes dead helper code. - Cleans the global MCI template JSON by removing runtime/system label fields.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/interface/rest/server/infra/manageInfo.go | Updates Swagger annotations for /configCopy 200 response documentation |
| src/interface/rest/docs/swagger.yaml | Updates generated OpenAPI 200 response schema/description for /configCopy |
| src/interface/rest/docs/docs.go | Updates generated Swagger 2.0 docs for /configCopy 200 response |
| src/core/model/common.go | Minor formatting change in ResourceTypeRegistry map |
| src/core/common/template.go | Prevents updating template Name on update; removes unused stub function |
| init/templates/global-mci-template.json | Removes system/runtime labels and revises description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.