Support parallel executions of vllm Benchmarking for gpu instances#2339
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Mar 3, 2026
Merged
Support parallel executions of vllm Benchmarking for gpu instances#2339cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Member
seokho-son
commented
Mar 3, 2026
- Support labelselector for built-in func
- Expand run_guidellm for multiple instance Benchmarking
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends LLM benchmarking and remote-command templating to better support multi-GPU-instance workflows by enabling label-based VM selection for IP expansion and allowing GuideLLM benchmarking to target multiple VM endpoints in one run.
Changes:
- Add optional
labelparameter support to$$Func(GetPublicIPs|GetPrivateIPs ...)to filter VMs via label selector before expanding IP lists. - Update GuideLLM telemetry script to accept multiple
--ipvalues and generate per-target output files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/core/infra/remoteCommand.go |
Adds label-selector-based filtering to GetPublicIPs/GetPrivateIPs built-in functions via getVmIdsByLabel. |
scripts/usecases/llm/telemetry/run_guidellm.sh |
Adds multi-target IP argument parsing and per-target result handling for GuideLLM benchmarking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.