Enhance llm telemetry export_metrics and gpu driver for remote cmd#2334
Merged
cb-github-robot merged 5 commits intocloud-barista:mainfrom Feb 28, 2026
Merged
Enhance llm telemetry export_metrics and gpu driver for remote cmd#2334cb-github-robot merged 5 commits intocloud-barista:mainfrom
cb-github-robot merged 5 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LLM operational scripts to better support remote, non-interactive usage: the telemetry exporter can now run with defaults or CLI flags (not only via a config file), and the GPU driver installers add pre-cleanup plus a more robust multi-candidate driver installation flow.
Changes:
- Add “remote-friendly” CLI parsing to
export_metrics.sh(defaults / CLI flags / legacy config mode). - Add NVIDIA driver pre-cleanup and iterative fallback installation across multiple driver package candidates.
- Add vGPU-vs-non-vGPU detection and ensure
nvidia-modprobeis installed to create/dev/nvidia*nodes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/usecases/llm/telemetry/export_metrics.sh | Adds CLI/default execution modes to support remote execution without a config file. |
| scripts/usecases/llm/installGpuDriver.sh | Adds NVIDIA package pre-cleanup, vGPU detection, candidate-based driver install loop, and nvidia-modprobe guard. |
| scripts/usecases/llm/installCudaDriver.sh | Mirrors the NVIDIA driver install robustness improvements for the CUDA-driver-focused script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But, this requires more testing.. endlessly ?? ;)