Fix k8s and llm-d scripts#2329
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Feb 25, 2026
Merged
Conversation
Member
seokho-son
commented
Feb 25, 2026
- enhance stability with additional procedures.
- not a main functionality. just an use case.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes/llm-d “usecase” scripts to follow the upstream llm-d helmfile-based installation flow, and expands prerequisite handling to improve unattended/remote stability.
Changes:
- Reworks
deploy-llm-d.shto deploy via a cloned llm-d repo +helmfile apply, adds new flags (HF token, tensor parallel, gateway/hardware env, NodePort, uninstall), and expands prereq checks. - Enhances
k8s-control-plane-setup.sh --llm-dto install additional tooling (helmfile, yq) and required CRDs/components (Gateway API, GAIE/InferencePool, Prometheus CRDs, Istio).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| scripts/usecases/llm/deploy-llm-d.sh | Switches to helmfile-based llm-d deployment with richer prereq checks, overrides, and uninstall/exposure options. |
| scripts/usecases/k8s/k8s-control-plane-setup.sh | Installs llm-d prerequisite tools/CRDs and attempts to provision a default Gateway control plane (Istio). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.