Allow more output size for ssh output stream#2328
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Feb 24, 2026
Merged
Allow more output size for ssh output stream#2328cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases output size limits for SSH command execution to better accommodate large outputs like base64-encoded kubeconfig files. It also improves the robustness of package manager process cleanup in Kubernetes setup scripts.
Changes:
- Increased maxLogLineLen from 4KB to 128KB for SSH command streaming via SSE
- Increased stdout/stderr history truncation limit from 1000 to 100000 bytes
- Replaced
pkillwith saferpgrep | xargs killpattern in K8s setup scripts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/core/infra/remoteCommand.go | Increases buffer sizes for SSH output streaming (4KB→128KB) and command history storage (1KB→100KB) |
| scripts/usecases/k8s/k8s-worker-setup.sh | Replaces aggressive pkill with controlled pgrep|xargs kill for apt/dpkg cleanup |
| scripts/usecases/k8s/k8s-control-plane-setup.sh | Same pkill to pgrep|xargs kill change as worker setup script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.