Enhance registrations for unknown resources#2322
Enhance registrations for unknown resources#2322cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
There was a problem hiding this comment.
Pull request overview
This PR enhances resource registration capabilities for cloud providers that don't follow the typical resource dependency patterns. It addresses two specific issues: Security Group registration for CSPs that don't bind security groups to VPCs (Azure, Tencent, NHN) and SSH key handling for GCP where SSH keys aren't independent resources.
Changes:
- Modified Security Group registration to allow empty VNetId for CSPs that don't associate security groups with VPCs
- Added placeholder SSH key creation mechanism for GCP VM registration when SSH keys aren't available as independent resources
- Introduced new system labels to mark placeholder resources that require user completion
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/model/securitygroup.go | Removed validation requirement for VNetId field to allow optional VPC association during registration |
| src/core/resource/securitygroup.go | Enhanced registration logic to handle empty VPC IDs and added validation for normal creation vs registration |
| src/core/model/label.go | Added new label constants for placeholder resources (LabelPlaceholder, LabelRequiresComplement) |
| src/core/resource/sshkey.go | Added CreatePlaceholderSshKey function to create placeholder SSH keys for GCP VMs |
| src/core/infra/provisioning.go | Enhanced VM registration to create placeholder SSH keys for GCP when no matching key is found |
| docker-compose.yaml | Added informational comment about updating Traefik image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
|
/approve |
|
Thanks to https://github.com/apps/copilot-pull-request-reviewer for the nice observation. ;) |
To fix