Skip to content

Fix registration/deregistration inconsistencies#2301

Merged
cb-github-robot merged 3 commits intocloud-barista:mainfrom
leehyeoklee:improve-registration
Jan 29, 2026
Merged

Fix registration/deregistration inconsistencies#2301
cb-github-robot merged 3 commits intocloud-barista:mainfrom
leehyeoklee:improve-registration

Conversation

@leehyeoklee
Copy link
Copy Markdown
Contributor

  1. Standardize Default Value (Subnet)
  • Changed the default value for undefined fields during Subnet registration from "not defined" to "unknown" to maintain consistency with other resources.
  1. Fix Missing Configuration (CustomImage)
  • Added the missing API URL configuration for customImage deregistration, which previously caused deregister requests to fail.
  1. Align Subnet ID Logic
  • Updated the Subnet registration logic to use NameId for the Id field.
  • This ensures the ID assignment logic is consistent with the creation process, where Id and Name are set to the same value.

https://github.com/cloud-barista/cb-tumblebug/blob/ec338fd591158ec36e8c55a44d7dbb8beff9cf48/src/core/resource/vnet.go#L547C4-L548C34

Copy link
Copy Markdown
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@seokho-son
Copy link
Copy Markdown
Member

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Jan 29, 2026
@cb-github-robot cb-github-robot merged commit 78deb49 into cloud-barista:main Jan 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This PR is approved and will be merged soon.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants