Enhance security group registration by resolving VNetId#2283
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Jan 22, 2026
Merged
Enhance security group registration by resolving VNetId#2283cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
seokho-son
reviewed
Jan 21, 2026
Member
seokho-son
left a comment
There was a problem hiding this comment.
@leehyeoklee Could you help reduce usage of the term IID ? It is not understandable concept and term in CB-TB code base in general. I know that it is not avoidable sometimes (only for interacting with CB-SP), but we should try to use CB-TB terms and concepts. :)
Contributor
Author
|
I changed the method to return SystemId directly instead of the IID struct, reducing the use of the IID term and concept! |
Member
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a issue in the Security Group registration logic where the VNet was being assigned arbitrarily.
1. Before (The Issue)
VNetIdfrom any VNet that shared the same Connection Name.2. After ( The Solution)
/getsecuritygroupownerAPI using the Security Group's CSP ID.NameId,SystemId) from the response.SystemId.u.VNetId.