Enable selective resource registration via option parameter by leehyeoklee · Pull Request #2274 · cloud-barista/cb-tumblebug

leehyeoklee · 2026-01-15T06:59:45Z

📝 Description

This PR enhances the resource registration process by introducing granular control over resource types via the option parameter. It also implements an early validation mechanism to enforce logical dependencies between resources, ensuring a "Fail-Fast" behavior for invalid requests.

🔍 Key Changes

1. Granular Resource Option Selection

Users can specify exactly which resource types to register via the option parameter.
Default Behavior: If the option parameter is omitted or empty, all resource types are registered by default.
Supported types: vNet, securityGroup, sshKey, vm, dataDisk, customImage.

2. Early Logical Dependency Validation (Fail-Fast)

Enforced strict dependency checks at the start of the flow (e.g., securityGroup requires vNet).

Invalid combinations are rejected immediately to prevent unnecessary processing.

3. Best Effort Execution & Error Handling

Once the initial validation passes, the registration process proceeds with a Best Effort strategy to handle various valid resource combinations.

For runtime failures caused by external factors rather than logical dependencies, the existing error handling logic is preserved:
e.g., If VM registration fails, the result is handled according to the specified MCI policy (continue, rollback, refine).

seokho-son

Thanks @leehyeoklee
LGTM in general!

I have a minor suggestion. :)

seokho-son · 2026-01-15T07:32:50Z

src/core/infra/utility.go

+	}

-	fmt.Printf("\n\n%s [Elapsed]Total %d \n\n", connConfig, int(math.Round(time.Now().Sub(startTime).Seconds())))
+	if doMap["securityGroup"] && !doMap["vNet"] {


How about using model.StrVNet instead of using the text directly? (applicable to the other resource types)

FYI: I think we need to refactor source code later for key stings for resource types in perspective of code maintenance. (currently, overall source code use both model.StrVNet and "vNet".)
I think we can make a package similar to CSP https://github.com/cloud-barista/cb-tumblebug/blob/main/src/core/model/csp/csp.go. and apply it to the existing codes.

No need to update it in this PR ;)

I went ahead and updated the code to use constants like model.StrVNet as suggested!
I totally agree that creating a dedicated package is the way to go for better maintenance.
I'll try to implement that structure in a future refactoring. Thanks! 😊

seokho-son · 2026-01-15T08:26:35Z

@leehyeoklee Also, please evaluate the effect from these changes (RegisterCspNativeResources) to other functions and API documentation referencing RegisterCspNativeResources.

for instance, RestRegisterCspNativeResources, RestPostScheduleRegisterCspResources (+ CreateScheduledJob) and so on. :)

…gistration options

leehyeoklee · 2026-01-15T09:49:06Z

I completely missed checking those parts. 😅
Fortunately, it seems the legacy options were only remaining in the documentation and comments.
I've checked and updated them all to match the changes!

Also, it appears that resources are successfully registered when running the scheduled job.

seokho-son

@leehyeoklee I guess we can apply the following suggestions.

seokho-son · 2026-01-15T11:00:42Z

src/core/infra/utility.go

-				result.RegisterationOverview.SshKey--
-				result.RegisterationOverview.Failed++
+	// [3] SecurityGroup
+	if doMap["securityGroup"] {


how about

Suggested change

if doMap["securityGroup"] {

if doMap[model.StrSecurityGroup] {

seokho-son · 2026-01-15T11:01:04Z

src/core/infra/utility.go

-				result.RegisterationOverview.SecurityGroup--
-				result.RegisterationOverview.Failed++
+	// [2] VNet
+	if doMap["vNet"] {


how about

Suggested change

if doMap["vNet"] {

if doMap[model.StrVNet] {

seokho-son · 2026-01-15T11:01:24Z

src/core/infra/utility.go

-				result.RegisterationOverview.DataDisk--
-				result.RegisterationOverview.Failed++
+	// [4] SSHKey
+	if doMap["sshKey"] {


Suggested change

if doMap["sshKey"] {

if doMap[model.StrSSHKey] {

seokho-son · 2026-01-15T11:01:46Z

src/core/infra/utility.go

-				ConnectionName: connConfig,
-				CspResourceId:  r.CspResourceId,
+	// [5] VM
+	if doMap["vm"] {


Suggested change

if doMap["vm"] {

if doMap[model.StrVM] {

seokho-son · 2026-01-15T11:02:01Z

src/core/infra/utility.go

-				result.RegisterationOverview.CustomImage--
-				result.RegisterationOverview.Failed++
+	// [6] DataDisk
+	if doMap["dataDisk"] {


Suggested change

if doMap["dataDisk"] {

if doMap[model.StrDataDisk] {

seokho-son

I have additional suggestions. :)

seokho-son · 2026-01-15T11:15:11Z

src/core/infra/utility.go

+	if doMap[model.StrDataDisk] && !doMap[model.StrVM] {
+		valErrs = append(valErrs, "'dataDisk' requires 'vm'")
+	}

-	fmt.Printf("\n\n%s [Elapsed]%s %d \n\n", connConfig, model.StrVM, int(math.Round(time.Now().Sub(startTime06).Seconds()))) //tmp
+	if doMap[model.StrVM] {
+		if !doMap[model.StrSecurityGroup] {
+			valErrs = append(valErrs, "'vm' requires 'securityGroup'")
+		}
+		if !doMap[model.StrSSHKey] {
+			valErrs = append(valErrs, "'vm' requires 'sshKey'")
+		}
+	}

-	fmt.Printf("\n\n%s [Elapsed]Total %d \n\n", connConfig, int(math.Round(time.Now().Sub(startTime).Seconds())))
+	if doMap[model.StrSecurityGroup] && !doMap[model.StrVNet] {
+		valErrs = append(valErrs, "'securityGroup' requires 'vNet'")
+	}

-	return result, err
+	if len(valErrs) > 0 {
+		return fmt.Errorf("Validation Failed: %s", strings.Join(valErrs, ", "))
+	}
+	return nil


how about the following style. (to minimize redundant codes)

we can centralize required resource dependency rules in one section.

Suggested change

if doMap[model.StrDataDisk] && !doMap[model.StrVM] {

valErrs = append(valErrs, "'dataDisk' requires 'vm'")

}

fmt.Printf("\n\n%s [Elapsed]%s %d \n\n", connConfig, model.StrVM, int(math.Round(time.Now().Sub(startTime06).Seconds()))) //tmp

if doMap[model.StrVM] {

if !doMap[model.StrSecurityGroup] {

valErrs = append(valErrs, "'vm' requires 'securityGroup'")

}

if !doMap[model.StrSSHKey] {

valErrs = append(valErrs, "'vm' requires 'sshKey'")

}

}

fmt.Printf("\n\n%s [Elapsed]Total %d \n\n", connConfig, int(math.Round(time.Now().Sub(startTime).Seconds())))

if doMap[model.StrSecurityGroup] && !doMap[model.StrVNet] {

valErrs = append(valErrs, "'securityGroup' requires 'vNet'")

}

return result, err

if len(valErrs) > 0 {

return fmt.Errorf("Validation Failed: %s", strings.Join(valErrs, ", "))

}

return nil

requiredDeps := map[string][]string{

model.StrDataDisk: {model.StrVM},

model.StrVM: {model.StrSecurityGroup, model.StrSSHKey},

model.StrSecurityGroup: {model.StrVNet},

}

valErrs := []string{}

for key, required := range requiredDeps {

if !doMap[key] {

continue

}

for _, dep := range required {

if !doMap[dep] {

valErrs = append(valErrs, fmt.Sprintf("'%s' requires '%s'", key, dep))

}

}

}

if len(valErrs) > 0 {

return fmt.Errorf("Validation Failed: %s", strings.Join(valErrs, ", "))

}

return nil

This map-based approach makes the dependency logic much clearer and easier to maintain.
Thanks for the improvement!

…ements

seokho-son

LGTM! :)

seokho-son · 2026-01-15T15:04:41Z

/approve

leehyeoklee added 5 commits January 14, 2026 19:07

Make resource registration options selectable per resource type

0c95481

Refactor RegisterCspNativeResourcesAll to include option validation

52ae4a1

Update option parameter to support multi-select in Swagger

111b682

Update comment for resource registration

d7a2fd9

Set default to register all resources when option is empty

d608acd

leehyeoklee requested review from seokho-son and yunkon-kim as code owners January 15, 2026 06:59

seokho-son reviewed Jan 15, 2026

View reviewed changes

seokho-son self-assigned this Jan 15, 2026

leehyeoklee added 2 commits January 15, 2026 18:09

Update documentation and comment to support specific resource type re…

e369eec

…gistration options

Refactor resource option handling to use model constants

2b08011

seokho-son reviewed Jan 15, 2026

View reviewed changes

leehyeoklee added 2 commits January 15, 2026 22:38

Refactor resource registration to use model constants for resource types

c57331f

Refactor validation logic to use a dependency map for resource requir…

8c46c59

…ements

seokho-son approved these changes Jan 15, 2026

View reviewed changes

github-actions bot approved these changes Jan 15, 2026

View reviewed changes

github-actions bot added the approved This PR is approved and will be merged soon. label Jan 15, 2026

cb-github-robot merged commit 137c375 into cloud-barista:main Jan 15, 2026
4 checks passed

	if doMap["securityGroup"] {
	if doMap[model.StrSecurityGroup] {

Conversation

leehyeoklee commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

🔍 Key Changes

1. Granular Resource Option Selection

2. Early Logical Dependency Validation (Fail-Fast)

3. Best Effort Execution & Error Handling

Uh oh!

seokho-son left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seokho-son commented Jan 15, 2026

Uh oh!

leehyeoklee commented Jan 15, 2026

Uh oh!

seokho-son left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seokho-son left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seokho-son left a comment

Choose a reason for hiding this comment

Uh oh!

seokho-son commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leehyeoklee commented Jan 15, 2026 •

edited

Loading