Allow empty MCI and make it reusable#2264
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Jan 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enables empty Multi-Cloud Infrastructure (MCI) support by introducing a new lifecycle status and adding appropriate validation guards. The changes allow MCIs to exist without VMs and be reused later, while preventing operations that require VM instances from executing on empty MCIs.
Changes:
- Added
StatusEmptyconstant for MCIs without VMs - Implemented status determination logic to distinguish between provisioning, failed, and truly empty MCIs
- Added validation checks to block VM-requiring operations (remote commands, monitoring agent installation) on empty MCIs
- Extended deletion logic to allow empty MCIs to be safely deleted
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core/model/mci.go | Added StatusEmpty constant to represent MCIs with no VMs |
| src/core/infra/remoteCommand.go | Added validation to prevent executing remote commands on empty MCIs |
| src/core/infra/monitoring.go | Added validation to prevent installing monitoring agents on empty MCIs |
| src/core/infra/manageInfo.go | Updated status determination logic to set StatusEmpty for MCIs without VMs and allowed deletion of empty MCIs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow empty MCI and make it reusable.
Empty)