Fix vLLM deployment script#2261
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Jan 8, 2026
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the bash version checking logic in the vLLM deployment script to properly handle different execution methods (piped vs direct execution).
Key changes:
- Added usage documentation explaining how to properly execute the script
- Enhanced bash version check to detect piped execution and provide appropriate error messages
- Improved user guidance when script is executed with an incompatible shell
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+16
| echo "Error: This script requires bash. Please use:" | ||
| echo " curl -fsSL <url> | bash" |
There was a problem hiding this comment.
The placeholder '' in the error message should be replaced with the actual URL or a more descriptive instruction. Users encountering this error won't know what URL to use. Consider either providing the actual URL to this script or using a clearer instruction like 'the script URL' instead of ''.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.