Add log skipper for internal API calls#2255
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Jan 5, 2026
Merged
Add log skipper for internal API calls#2255cb-github-robot merged 2 commits intocloud-barista:mainfrom
cb-github-robot merged 2 commits intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a centralized log filtering system to reduce verbose logging from internal API calls, refactors service initialization with parallel startup, and improves log message consistency across the codebase.
- Adds new
logfilterpackage with three types of skip patterns: Request logging, API logging, and Internal call logging - Refactors
main.goinitialization to use concurrent goroutines for waiting on PostgreSQL, CB-Spider, and etcd services - Updates all log messages with consistent prefixes (init:, setup:, config:, migrate:, main:) for better traceability
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/common/logfilter/patterns.go | New package defining centralized log skip patterns with method-aware filtering using SkipRule struct |
| src/main.go | Refactors service initialization to run concurrently, removes unused credentials loading, adds consistent log message prefixes |
| src/interface/rest/server/server.go | Migrates skip patterns to logfilter package, updates pattern matching logic to use SkipRule |
| src/interface/rest/server/middlewares/zerologger.go | Updates middleware to use SkipRule from logfilter package with method-aware filtering |
| src/core/common/client/client.go | Adds shouldSkipInternalCallLog function to filter high-frequency internal API calls from logs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now CB-TB support log skip patterns for 3 points.