Apply cb-spider:0.12.5 and its API changes#2250
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Jan 2, 2026
Merged
Apply cb-spider:0.12.5 and its API changes#2250cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the cb-spider dependency from version 0.12.0 to 0.12.5 and adapts the codebase to accommodate API changes introduced in the new version. The main API change involves the VM price info endpoint switching from POST to GET with query parameters instead of a request body.
Key changes:
- Updated cb-spider Docker image from 0.12.0 to 0.12.5
- Refactored price lookup API call to use GET method with query parameters
- Enhanced init.py progress indicator with a smoother spinner and better TTY/non-TTY handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Updates cb-spider Docker image version to 0.12.5 |
| src/core/resource/spec.go | Adapts LookupPriceList function to use GET method with ConnectionName and region as query parameters instead of POST with request body |
| init/init.py | Replaces progress bar with spinner animation, adds TTY detection for better display in different environments, and increases default expected completion time to 400 seconds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply cb-spider:0.12.5 and its API changes
v0.12.3
API Changes
Get VM Price Info:
Also, this PR enhance init.py progress bar