Add skipVersionCheck option for K8s#2222
Merged
cb-github-robot merged 2 commits intocloud-barista:mainfrom Nov 25, 2025
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
PTAL @hanizang77 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a skipVersionCheck query parameter to Kubernetes cluster creation and upgrade APIs, enabling developers to bypass version validation during development and testing with unlisted K8s versions.
Key Changes:
- Added
skipVersionCheckboolean query parameter toRestPostK8sClusterandRestPutUpgradeK8sClusterendpoints - Modified validation functions (
validateAtCreateK8sClusterandvalidateAtUpgradeK8sCluster) to conditionally skip version checks - Updated Swagger documentation to reflect the new parameter
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/interface/rest/server/resource/k8scluster.go | Added query parameter parsing and updated function calls to pass skipVersionCheck flag to create and upgrade functions |
| src/interface/rest/docs/swagger.yaml | Added skipVersionCheck parameter definition to OpenAPI spec for both create and upgrade endpoints |
| src/interface/rest/docs/docs.go | Generated documentation reflecting the new skipVersionCheck parameter |
| src/core/resource/k8scluster.go | Updated function signatures and validation logic to support conditional version checking with appropriate warning logs |
| src/core/infra/provisioning.go | Updated dynamic cluster creation to pass skipVersionCheck=false by default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add skipVersionCheck option for K8s.