Addtional description for ID management#2204
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Nov 6, 2025
Merged
Addtional description for ID management#2204cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the documentation for CB-Tumblebug's namespace and resource identity management by adding detailed information about the CspResourceId field and its relationship with Spider's SystemId.
Key changes:
- Documents the four-level identifier system (Id, Uid, CspResourceName, CspResourceId)
- Explains the distinction between CspResourceName (Spider's NameId) and CspResourceId (CSP's SystemId)
- Provides detailed use cases for CspResourceId including resource registration, traceability, and cross-reference validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+285
to
+286
| for i, spSubnetInfo := range spResp.SubnetInfoList { | ||
| vNetInfo.SubnetInfoList[i].CspResourceId = spSubnetInfo.IId.SystemId |
There was a problem hiding this comment.
The code example simplifies the subnet loop implementation. The actual code uses a nested loop to match subnets by Uid, not a simple index-based iteration. Consider updating this to match the actual implementation:
// 7. Also store subnet CSP IDs (match by Uid, not index)
for _, spSubnetInfo := range spResp.SubnetInfoList {
for i, tbSubnetInfo := range vNetInfo.SubnetInfoList {
if tbSubnetInfo.Uid == spSubnetInfo.IId.NameId {
vNetInfo.SubnetInfoList[i].CspResourceId = spSubnetInfo.IId.SystemId
vNetInfo.SubnetInfoList[i].CspResourceName = spSubnetInfo.IId.NameId
}
}
}This is important because the order of subnets in the response may differ from the request.
Suggested change
| for i, spSubnetInfo := range spResp.SubnetInfoList { | |
| vNetInfo.SubnetInfoList[i].CspResourceId = spSubnetInfo.IId.SystemId | |
| // 7. Also store subnet CSP IDs (match by Uid, not index) | |
| for _, spSubnetInfo := range spResp.SubnetInfoList { | |
| for i, tbSubnetInfo := range vNetInfo.SubnetInfoList { | |
| if tbSubnetInfo.Uid == spSubnetInfo.IId.NameId { | |
| vNetInfo.SubnetInfoList[i].CspResourceId = spSubnetInfo.IId.SystemId | |
| vNetInfo.SubnetInfoList[i].CspResourceName = spSubnetInfo.IId.NameId | |
| } | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.