Skip to content

Fix security group protocol handling for ALL and ICMP types#2198

Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom
yunkon-kim:fix-sg-creation-logic
Nov 6, 2025
Merged

Fix security group protocol handling for ALL and ICMP types#2198
cb-github-robot merged 1 commit intocloud-barista:mainfrom
yunkon-kim:fix-sg-creation-logic

Conversation

@yunkon-kim
Copy link
Copy Markdown
Member

@yunkon-kim yunkon-kim commented Nov 5, 2025

This PR will update the security group handling logic.

Updated

  • Handle ALL and ICMP protocols by setting FromPort/ToPort to "-1" for Spider API
  • Skip port validation for ALL and ICMP protocols in security group creation
  • Add ALL protocol check in Spider-to-Tumblebug conversion to set empty port string

Note

  • Due to Beetle integration testing work, this PR has been modified based on Tumblebug v0.11.15.

@yunkon-kim
Fix security group protocol handling for ALL and ICMP types
9ac6a8e 
- Handle ALL and ICMP protocols by setting FromPort/ToPort to "-1" for Spider API
- Skip port validation for ALL and ICMP protocols in security group creation
- Add ALL protocol check in Spider-to-Tumblebug conversion to set empty port string
This was referenced Nov 5, 2025
Merged
Closed
Closed
@yunkon-kim
Copy link
Copy Markdown
Member Author

yunkon-kim commented Nov 5, 2025

I would like to ask the code owner @seokho-son for a review.

@seokho-son
Copy link
Copy Markdown
Member

seokho-son commented Nov 6, 2025

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Nov 6, 2025
@cb-github-robot cb-github-robot merged commit fdcf24d into cloud-barista:main Nov 6, 2025
5 checks passed
@yunkon-kim
Copy link
Copy Markdown
Member Author

yunkon-kim commented Nov 6, 2025 •
edited
Loading

On MapUI, I couldn't update firewall rules;;;

I tested it on the latest source build version and also v0.11.19.

What I had done was as follows:

  • First, I deleted all existing outbound rules.
  • When I requested adding an outbound all rule,
    • it just appeared to be in progress for a while, and
    • "portElement.var couldn't be found" came in the browser console.
  • When I requested adding an outbound all rule for all security groups, "an invalid request" was returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

Assignees

No one assigned

Labels

approved This PR is approved and will be merged soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yunkon-kim @seokho-son @cb-github-robot