Reduce verbose debug log contents#2134
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Sep 3, 2025
Merged
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces verbose debug logging throughout the application to improve log readability and performance by commenting out detailed debug statements and adjusting log levels.
- Commented out detailed debug logs in spec filtering and processing operations
- Changed an info-level log to debug level in recommendation ordering
- Updated distance band thresholds in location-based ordering logic
- Fixed Go style issues and increased debug body length limit
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/core/resource/spec.go | Commented out verbose debug logs during spec filtering and processing, added TODO comment |
| src/core/infra/recommendation.go | Changed order-by log from info to debug level, updated distance band thresholds |
| src/core/common/utility.go | Removed unused variable in range loop |
| src/core/common/client/client.go | Increased debug body length limit and improved truncation message |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Int("ignoredSpecs", ignoredCount). | ||
| Int("processedSpecs", int(specCount)). | ||
| Msgf("Spec processing completed: %d/%d specs processed (%d ignored)", | ||
| Msgf("Spec processing completed: %d/%d (%d ignored)", |
There was a problem hiding this comment.
[nitpick] The log message format is inconsistent with the previous pattern. Consider keeping the 'specs processed' terminology for clarity: Msgf(\"Spec processing completed: %d/%d specs processed (%d ignored)\",
Suggested change
| Msgf("Spec processing completed: %d/%d (%d ignored)", | |
| Msgf("Spec processing completed: %d/%d specs processed (%d ignored)", |
Comment on lines
+69
to
+74
| // Fast integer approximation: ~7 bytes per word in JSON | ||
| bodyWords := bodyLength / 7 | ||
| limitWords := MaxDebugBodyLength / 7 | ||
|
|
||
| return fmt.Sprintf(`{"message":"Response body %d words (%d bytes) exceeds limit %d words (%d bytes). Use TRACE level to log and check content."}`, | ||
| bodyWords, bodyLength, limitWords, MaxDebugBodyLength) |
There was a problem hiding this comment.
[nitpick] The word count calculation using integer division by 7 is an approximation that may be confusing. Consider adding a comment explaining this is an estimate, or use a more descriptive variable name like estimatedWords.
Suggested change
| // Fast integer approximation: ~7 bytes per word in JSON | |
| bodyWords := bodyLength / 7 | |
| limitWords := MaxDebugBodyLength / 7 | |
| return fmt.Sprintf(`{"message":"Response body %d words (%d bytes) exceeds limit %d words (%d bytes). Use TRACE level to log and check content."}`, | |
| bodyWords, bodyLength, limitWords, MaxDebugBodyLength) | |
| // Fast integer approximation: ~7 bytes per word in JSON; this is an estimate, not an exact word count | |
| estimatedWords := bodyLength / 7 | |
| estimatedLimitWords := MaxDebugBodyLength / 7 | |
| return fmt.Sprintf(`{"message":"Response body estimated at %d words (%d bytes) exceeds limit of %d words (%d bytes). Use TRACE level to log and check content."}`, | |
| estimatedWords, bodyLength, estimatedLimitWords, MaxDebugBodyLength) |
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.