Add SubGroup request review feature and refactor naming#2121
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Aug 28, 2025
Merged
Add SubGroup request review feature and refactor naming#2121cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the naming convention from VM-based to SubGroup-based terminology for dynamic MCI (Multi-Cloud Infrastructure) operations and adds a new SubGroup request review feature. The changes promote consistency in the codebase by standardizing on "SubGroup" terminology throughout the API endpoints, function names, and data models.
- Rename VM dynamic endpoints and functions to SubGroup dynamic equivalents
- Add new SubGroup dynamic review endpoint for pre-validation of VM addition requests
- Update API documentation and Swagger specifications to reflect the new naming
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/interface/rest/server/server.go | Updates REST API routes from vmDynamic to subGroupDynamic and adds new review endpoint |
| src/interface/rest/server/infra/provisioning.go | Renames functions and adds new review endpoint implementation |
| src/interface/rest/docs/swagger.yaml | Updates OpenAPI specification with new endpoint paths and operation IDs |
| src/interface/rest/docs/swagger.json | Updates JSON OpenAPI specification to match YAML changes |
| src/interface/rest/docs/docs.go | Updates generated Go documentation constants |
| src/core/model/mci.go | Renames struct types and fields from VmDynamic to SubGroupDynamic |
| src/core/infra/provisioning.go | Refactors core logic functions and adds new review functionality |
| src/core/infra/orchestration.go | Updates field references to use new SubGroup naming |
| docs/migration_guide_0.11.1_to_0.11.8.md | Updates migration documentation with corrected naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.