Disable recommending NHN Cloud hold deployment#2113
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Aug 25, 2025
Merged
Disable recommending NHN Cloud hold deployment#2113cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Member
seokho-son
commented
Aug 25, 2025
- We now support VM provisioning for NHN Cloud with Internet gateway setting.
- No need to add review warning for NHN Cloud hold deployment
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the review warnings and restrictions for NHN Cloud deployments that previously forced users to use 'hold' deployment mode. The change enables automatic VM provisioning for NHN Cloud now that Internet gateway settings are supported.
- Commented out NHN Cloud deployment validation logic that required 'hold' mode
- Removed error conditions that blocked non-hold deployments for NHN Cloud
- Eliminated warnings about manual deployment requirements for NHN Cloud
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+1772
to
+1784
| // // Check NHN Cloud limitations | ||
| // if providerName == csp.NHN { | ||
| // if deployOption != "hold" { | ||
| // vmReview.Errors = append(vmReview.Errors, "NHN Cloud can only be provisioned with deployOption 'hold' (manual deployment required)") | ||
| // vmReview.CanCreate = false | ||
| // viable = false | ||
| // log.Debug().Msgf("NHN Cloud requires 'hold' deployOption for VM: %s", subGroupDynamicReq.Name) | ||
| // } else { | ||
| // vmReview.Warnings = append(vmReview.Warnings, "NHN Cloud requires manual deployment completion after 'hold' - automatic provisioning is not fully supported") | ||
| // hasVmWarning = true | ||
| // log.Debug().Msgf("NHN Cloud 'hold' mode warning for VM: %s", subGroupDynamicReq.Name) | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Instead of commenting out this code block, consider removing it entirely since NHN Cloud now supports automatic provisioning. Commented-out code reduces readability and can cause confusion about whether this logic might be re-enabled in the future.
Suggested change
| // // Check NHN Cloud limitations | |
| // if providerName == csp.NHN { | |
| // if deployOption != "hold" { | |
| // vmReview.Errors = append(vmReview.Errors, "NHN Cloud can only be provisioned with deployOption 'hold' (manual deployment required)") | |
| // vmReview.CanCreate = false | |
| // viable = false | |
| // log.Debug().Msgf("NHN Cloud requires 'hold' deployOption for VM: %s", subGroupDynamicReq.Name) | |
| // } else { | |
| // vmReview.Warnings = append(vmReview.Warnings, "NHN Cloud requires manual deployment completion after 'hold' - automatic provisioning is not fully supported") | |
| // hasVmWarning = true | |
| // log.Debug().Msgf("NHN Cloud 'hold' mode warning for VM: %s", subGroupDynamicReq.Name) | |
| // } | |
| // } |
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.