Refactor for applying changed CSP names#2108
Refactor for applying changed CSP names#2108cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Cloud Service Provider (CSP) naming conventions, simplifying provider names to improve consistency and readability across the codebase:
- Standardizes CSP names by removing VPC suffixes and abbreviating NHN Cloud
- Updates configuration files, scripts, and documentation to align with new naming
- Increments version to 0.11.7 with corresponding component updates
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/testclient/scripts/testSet.env | Updates CSP index variables and mappings for renamed providers |
| src/testclient/scripts/sequentialFullTest/*.sh | Replaces old CSP names in conditional logic and script calls |
| src/testclient/scripts/conf.env | Updates provider configurations and connection mappings |
| src/core/model/csp/csp.go | Changes CSP constant definitions from verbose to simplified names |
| src/core/resource/*.go | Updates CSP name references in resource handling logic |
| docker-compose.yaml | Bumps version numbers for service images |
| assets/*.yaml | Updates configuration files with new CSP names |
| init/template.credentials.yaml | Changes credential template keys to match new naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| {"/tumblebug/readyz"}, | ||
| {"/tumblebug/httpVersion"}, | ||
| {"/mci", "option=status"}, | ||
| {"/mci"}, |
There was a problem hiding this comment.
This appears to be an unrelated addition to the PR. Adding a new endpoint {"/mci"} to the rate limiting configuration doesn't relate to the CSP naming refactor and may introduce unintended behavior changes.
| {"/mci"}, |
| IndexOpenstack=$((++IX)) | ||
| IndexNCP=$((++IX)) | ||
| IndexNCPVPC=$((++IX)) | ||
| IndexNCP=$((++IX)) |
There was a problem hiding this comment.
Duplicate IndexNCP assignment. Both line 28 (IndexNCP) and line 29 (IndexNCP) are being assigned the same incremented value, which will cause IndexCloudit to have an incorrect index value.
| IndexNCP=$((++IX)) |
| CSPType[$IndexOpenstack]=openstack | ||
| CSPType[$IndexNCP]=ncp | ||
| CSPType[$IndexNCPVPC]=ncpvpc | ||
| CSPType[$IndexNCP]=ncp |
There was a problem hiding this comment.
Duplicate CSPType assignment for IndexNCP. This overwrites the previous assignment on line 47, potentially causing configuration issues.
| CSPType[$IndexNCP]=ncp |
| CSPIndex=$IndexNCPVPC | ||
| elif [ "${CSP}" == "ncp" ]; then | ||
| # echo "[NCP driver]" | ||
| CSPIndex=$IndexNCP |
There was a problem hiding this comment.
Duplicate condition for 'ncp' CSP. Both lines 2854 and 2857 check for the same CSP value 'ncp', which means the second condition will never be reached.
| CSPIndex=$IndexNCP |
| # echo "[NCPVPC driver]" | ||
| elif [ "${CSP}" == "ncp" ]; then | ||
| # echo "[NCP driver]" | ||
| CSPIndex=l |
There was a problem hiding this comment.
Another duplicate condition for 'ncp' CSP in the getCloudIndexGeneral function. This creates the same issue where the second ncp condition is unreachable.
| CSPIndex=l |
|
/approve |
This PR will staging v0.11.7 as well