Sort making searchImage result with basic images front#2103
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Aug 20, 2025
Merged
Sort making searchImage result with basic images front#2103cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Member
seokho-son
commented
Aug 20, 2025
Signed-off-by: Seokho Son <shsongist@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements sorting functionality to prioritize basic images in search results by moving them to the front of the returned image list.
- Adds an efficient O(n) partitioning algorithm to move basic images to the beginning of search results
- Uses an in-place swapping approach to maintain memory efficiency
- Preserves the relative order of basic images while ensuring they appear before non-basic images
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
|
|
||
| // Move basic images to the front using partition approach (O(n) instead of O(n log n)) |
There was a problem hiding this comment.
[nitpick] The comment mentions O(n log n) comparison but doesn't specify what operation this refers to. Consider clarifying that this is comparing against a sorting-based approach, e.g., '// Move basic images to the front using partition approach (O(n) instead of O(n log n) sort-based approach)'
Suggested change
| // Move basic images to the front using partition approach (O(n) instead of O(n log n)) | |
| // Move basic images to the front using partition approach (O(n) instead of O(n log n) sort-based approach) |
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.