Disable mci failure status from upfront#2099
Disable mci failure status from upfront#2099cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR disables the MCI (Multi-Cloud Infrastructure) failure status reporting from the frontend by commenting out failure status logic and updating a function call to use an internal variant.
- Comments out the MCI failure status representation logic in the Go backend
- Updates Python function call to use internal validation variant
- Maintains existing status reporting for other states while removing failure status display
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/interface/mcp/tb-mcp.py | Changes function call to use internal namespace validation variant |
| src/core/infra/manageInfo.go | Comments out MCI failure status logic to disable frontend failure reporting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| mciStatus.Status = statusFlagStr[0] + proportionStr | ||
| } | ||
| } | ||
| // // for representing Failed status in front. |
There was a problem hiding this comment.
Double comment prefix '//' is unnecessary. Use single '//' for commented code.
| // // for representing Failed status in front. | |
| // for representing Failed status in front. |
| } | ||
| // // for representing Failed status in front. | ||
|
|
||
| // proportionStr = ":" + strconv.Itoa(statusFlag[0]) + " (R:" + strconv.Itoa(runningStatus) + "/" + strconv.Itoa(numVm) + ")" |
There was a problem hiding this comment.
[nitpick] Consider removing commented code blocks entirely rather than leaving them in the codebase. If this logic needs to be preserved for future reference, consider using version control history or documenting the reasoning in a proper comment.
|
/approve |
No description provided.