Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR prepares for the 0.11.4 staging release by updating Docker image versions across the compose file and modifying CSP (Cloud Service Provider) configuration for NCP support in the label synchronization system.
- Updates Docker images to newer versions across multiple services (cb-tumblebug, cb-spider, cb-mapui, and traefik)
- Modifies NCP configuration in the CSP sync skip configuration - adds general NCP skip flag while commenting out resource-specific skip rules
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docker-compose.yaml | Updates container image versions for traefik, cb-tumblebug, cb-spider, and cb-mapui services |
| src/core/common/label/label.go | Adds NCP to general CSP skip list and comments out NCP-specific resource skip configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| // csp.NCP: true, | ||
| csp.NHNCloud: true, | ||
| csp.GCP: true, // GCP supports tags, but there are some restrictions on naming conventions | ||
| csp.NCP: true, // Not supported by CB-Spider |
There was a problem hiding this comment.
Adding NCP to the general skip list while commenting out its specific resource configurations creates inconsistent behavior. If NCP is not supported by CB-Spider, the commented-out resource-specific configurations should either be removed entirely or the general skip flag should be reconsidered to maintain configuration clarity.
|
/approve |
No description provided.