feat: comprehensive security group firewall rules management system#2065
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Aug 2, 2025
Merged
feat: comprehensive security group firewall rules management system#2065cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
…verhaul Core Model Redesign: - Add TbFirewallRuleReq struct with Ports field supporting comma-separated multiple ports/ranges - Refactor TbFirewallRuleInfo to use single Port field for individual rule representation - Add comprehensive response models: TbSecurityGroupUpdateResponse, TbRestWrapperSecurityGroupUpdateResponse, TbUpdateSummary - Add MciAssociatedResourceList struct for complete MCI-resource relationship tracking Backend Logic Enhancement: - Implement ConvertFirewallRuleRequestObjToInfoObjs for flexible multi-port request conversion - Major UpdateFirewallRules refactor with CSP-aware conditional processing (sequential for NCP, parallel for others) - Add UpdateMultipleFirewallRules with goroutine-based parallel processing and comprehensive error handling - Enhance diffFirewallRules with duplicate removal and default rule protection logic - Improve ICMP protocol handling and port validation with proper empty port support - Add GetMciAssociatedResources for complete MCI resource dependency analysis REST API Complete Redesign: - Remove TbFirewallRulesWrapper, standardize on TbSecurityGroupUpdateReq across all endpoints - Comprehensive POST/DELETE firewall rule API redesign with detailed Swagger documentation - Add RestGetMciAssociatedResources and RestPutMciAssociatedSecurityGroups for MCI-level operations - Implement unified response format with TbSecurityGroupUpdateResponse for consistency - Add clear REST semantics: POST for adding rules, DELETE for removing specific rules, PUT for replacing all rules Infrastructure & Documentation: - Add new API endpoint routing and comprehensive Swagger documentation updates - Support batch operations with detailed success/failure tracking and summary reporting - Enhanced error handling with provider-specific processing strategies for improved stability Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core Model Redesign:
Backend Logic Enhancement:
REST API Complete Redesign:
Infrastructure & Documentation: