feat: refactor Security Group firewall rule model and update logic#2063
Merged
cb-github-robot merged 1 commit intocloud-barista:mainfrom Jul 30, 2025
Merged
feat: refactor Security Group firewall rule model and update logic#2063cb-github-robot merged 1 commit intocloud-barista:mainfrom
cb-github-robot merged 1 commit intocloud-barista:mainfrom
Conversation
Member
seokho-son
commented
Jul 30, 2025
- Change firewall rule model to use Ports (string) instead of FromPort/ToPort
- Add protocol-specific handling (ICMP, ALL) and port validation logic
- Implement robust diff logic for AWS-style rule overlap/replace on update
- Add conversion functions between Spider and Tb firewall rule structs
- Implement and document REST API handler for synchronizing firewall rules
- Update Swagger docs and OpenAPI spec with new model, usage, and examples
- Change firewall rule model to use Ports (string) instead of FromPort/ToPort - Add protocol-specific handling (ICMP, ALL) and port validation logic - Implement robust diff logic for AWS-style rule overlap/replace on update - Add conversion functions between Spider and Tb firewall rule structs - Implement and document REST API handler for synchronizing firewall rules - Update Swagger docs and OpenAPI spec with new model, usage, and examples Signed-off-by: Seokho Son <shsongist@gmail.com>
Member
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.