Update material components 0.13.0 build fix#1218
Merged
Deraen merged 2 commits intocljsjs:masterfrom Jun 19, 2017
Merged
Conversation
Contributor
Author
|
I'm not quite sure how this fails, Running the cljsjs/build-image:0.0.3, I get a successful build. The only difference I can think of is the cache layer, but the full build log is attached. |
Member
|
Doesn't seem like it was the cache layer. Probably bad file permissions in node modules folder. |
Member
|
Arrgghhjhjh, I hate npm. I changed all the files with bad UID in docker image to root, but npm install still creates files with non-existing UID. |
Member
UID 501 does not exist. |
Member
|
I deployed this manually as Node 8 doesn't work on CI and this can't be built with Node 6, or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #1208. It's the same, but successfully fixes #1203. I tested it on the new circleci Docker image.
Update:
Extern: The API did not change.
I have updated to 0.13.0, as that was released recently, and I also changed sh to dosh.
dosh allows circleci to fail if the build doesn't work. It built fine on node 8.1.0 on my local MacMini.
It seems that there was an issue with postinstall not being run, so I run it automatically now.