Support joins in an association's scope for preloading#51
Closed
kadenbarlow wants to merge 1 commit intoclio:masterfrom
Closed
Support joins in an association's scope for preloading#51kadenbarlow wants to merge 1 commit intoclio:masterfrom
kadenbarlow wants to merge 1 commit intoclio:masterfrom
Conversation
Author
|
Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went to go update jit_preloader (was on a version that didn't have the STI changes yet, and it broke several has_many_aggregates. The reason was that the table_reference was incorrect because these has_many_aggregates had a join in their scope along with a where and the current code didn't take that into account. Don't know if this is the best way to go about it but it does solve the problem I was facing.