chore(ci): remove ai review workflows and publish caching#9211
chore(ci): remove ai review workflows and publish caching#9211saoudrizwan merged 2 commits intomainfrom
Conversation
|
|
JetBrains Plugin tests failed ❌ The changes in this PR are causing test failures in the JetBrains plugin integration. Please review and fix your changes to ensure they work properly with:
Please check the workflow logs for specific test failure details and update your PR accordingly. Branch: |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the repository’s GitHub Actions setup by removing automated AI PR review/issue triage workflows and eliminating dependency caching from publish-related workflows.
Changes:
- Removed AI review/triage workflow files (
cline-pr-review,claude-pr-review,claude-issue-triage). - Removed
actions/cacheusage from extension publish and NPM publish workflows. - Adjusted install steps to run unconditionally (by removing cache-hit conditionals).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Removes dependency caching steps from the release publish workflow. |
| .github/workflows/publish-nightly.yml | Removes dependency caching steps from the nightly extension publish workflow. |
| .github/workflows/npm-nightly.yaml | Removes dependency caching step from the nightly NPM publish workflow. |
| .github/workflows/npm-main.yaml | Removes dependency caching step from the main/manual NPM publish workflow. |
| .github/workflows/cline-pr-review.yml | Deletes the Cline-based automated PR review workflow. |
| .github/workflows/claude-pr-review.yml | Deletes the Claude-based automated PR review workflow. |
| .github/workflows/claude-issue-triage.yml | Deletes the Claude-based automated issue triage workflow. |
Comments suppressed due to low confidence (1)
.github/workflows/publish-nightly.yml:45
Check for recent commitscurrently usesexit 0, which only ends that step; the job will still proceed to install/build/publish. If the intent is to skip publishing when there were no commits, set an output (e.g.,skip=true/false) and gate subsequent steps (or the whole job) with anif:condition based on that output.
- name: Install root dependencies
run: npm ci --include=optional
- name: Install webview-ui dependencies
run: cd webview-ui && npm ci --include=optional
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| key: ${{ runner.os }}-npm-${{ hashFiles('package-lock.json') }} | ||
|
|
||
| - name: Install root dependencies and CLI dependencies | ||
| if: steps.check_commits.outputs.skip != 'true' |
There was a problem hiding this comment.
This step has an if: steps.check_commits.outputs.skip != 'true', but there is no check_commits step (or any other step with id: check_commits) in this workflow. Either add the missing step that sets the output, or remove the if: condition so the workflow logic is clear and intentional.
| if: steps.check_commits.outputs.skip != 'true' |
| - name: Install root dependencies | ||
| if: steps.root-cache.outputs.cache-hit != 'true' | ||
| run: npm install --include=optional |
There was a problem hiding this comment.
This PR removes .github/workflows/cline-pr-review.yml, but the docs still reference that workflow and link to it (e.g., docs/cline-cli/samples/github-pr-review.mdx and docs/cline-cli/samples/model-orchestration.mdx). Consider updating those docs in the same PR (or keeping the workflow as a documented sample elsewhere) to avoid broken links/instructions.
| - name: Install root dependencies | ||
| if: steps.root-cache.outputs.cache-hit != 'true' | ||
| run: npm install --include=optional | ||
|
|
||
| - name: Install webview-ui dependencies | ||
| if: steps.webview-cache.outputs.cache-hit != 'true' | ||
| run: cd webview-ui && npm install --include=optional |
There was a problem hiding this comment.
For CI/release builds, using npm install can produce non-deterministic results (it may update package-lock.json and does not strictly enforce lockfile resolution). This repo’s other workflows use npm ci, so consider switching both dependency install steps here to npm ci --include=optional for reproducible publishes.
Related Issue
Issue: N/A
Description
Removing the AI review/triage workflow files and removing caching from publish workflows.
Test Procedure
Not applicable.
Type of Change
Pre-flight Checklist
npm test) and code is formatted and linted (npm run format && npm run lint)npm run changeset(required for user-facing changes)Screenshots
Not applicable.
Additional Notes
Removing workflow files and publish workflow caching.
Important
Remove AI review workflows and caching from publish workflows in CI/CD process.
claude-issue-triage.yml,claude-pr-review.yml, andcline-pr-review.ymlworkflows.npm-main.yaml,npm-nightly.yaml,publish-nightly.yml, andpublish.ymlworkflows.This description was created by
for ff395e0. You can customize this summary. It will automatically update as commits are pushed.