support for click 8 completion changes#76
Merged
auvipy merged 2 commits intoclick-contrib:masterfrom May 28, 2021
Merged
Conversation
|
I have tested this PR on one of our projects that use click-repl (zhmcclient/zhmccli#173) and it installs fine with click 8.0 and also the auto-completion works fine. |
Contributor
Author
|
Hey @auvipy Any chance to accept this PR? Thanks |
|
A merge and subsequent release of a new version would be much appreciated, as the upgrade to click has broken downstreams (such as Arch Linux: FS#71044). |
auvipy
approved these changes
May 28, 2021
Collaborator
|
@auvipy the changes look fine, yes :) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple migration from
_bashcompletetoshell_completion. Fixes #72.