Add accessibility package and isEnabled function #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfeller
requested changes
Feb 7, 2025
Member
andyfeller
left a comment
There was a problem hiding this comment.
Color me impressed with how quick you got this up 😮 Handful of minor things I suspect are quick to knock out.
9ca7222 to
794568b
Compare
| // accessibility features. If the value is empty, "0", or "false", the accessibility | ||
| // features are disabled. Any other value enables the accessibility features. Note that | ||
| // this environment variable supercedes the configuration file's accessible setting. | ||
| const ACCESSIBILITY_ENV = "ACCESSIBILE" |
Member
There was a problem hiding this comment.
This is spelt incorrectly. "ACCESSIBILE" -> "ACCESSIBLE"
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
stubConfig()function to utilaccessibilitypackage andIsEnabled()functionTesting
This isn't wired up to anything yet, so unless its wired up to its own binary it is just covered by the unit tests. I think this is fine given we're merging into a feature branch right now.