Skip to content

Match hostnames case-insensitively#105

Closed
mislav wants to merge 3 commits intotrunkfrom
case-insensitive-hostnames
Closed

Match hostnames case-insensitively#105
mislav wants to merge 3 commits intotrunkfrom
case-insensitive-hostnames

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Feb 16, 2023

TODO:

  • check if the change to FindEntry will affect alias resolution?

TODO:
- check if this will affect alias resolution
@mislav
Copy link
Contributor Author

mislav commented Apr 17, 2023

To avoid affecting case-sensitive alias resolution, I ideally wanted to perform case-insensitive lookups only for keys under hosts, but doing so required more changes to the implementation I was comfortable with, and the overall approach still feels brittle. Shelving this for now and making a simple workaround in the cli/cli repo.

@mislav mislav closed this Apr 17, 2023
@mislav mislav deleted the case-insensitive-hostnames branch April 17, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant