Rework sigstore tests #9005
Closed
Rework sigstore tests #9005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change is previously we always instantiated a TUF client for the public good and GitHub Sigstore instances. Now we only instantiate the TUF client we need, or no client if we are provided a custom trusted root. Note that `gh attestation verify` still requires authentication, that is being addressed in #8995. Some other changes are coming along for the ride: - Set TUF cache validity to 1 day, to help serial verification - Attempt to infer verification policy based on custom trusted root - Make command output more friendly if you leave off required arguments Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Member
Author
|
Commits were pulled into #8997 |
Angelface89
reviewed
May 11, 2024
Angelface89
left a comment
There was a problem hiding this comment.
I didn't do these some one else has off my acct pls take the time and inspect all of the stuff made on this site as I didn't even have a guy hub until a few days ago I don't even know how to use it
| opts := &Options{} | ||
| downloadCmd := &cobra.Command{ | ||
| Use: "download [<file-path> | oci://<image-uri>] [--owner | --repo]", | ||
| Args: cmdutil.MinimumArgs(1, "must specify file path or container image URI, as well as one of --owner or --repo"), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| opts := &Options{} | ||
| downloadCmd := &cobra.Command{ | ||
| Use: "download [<file-path> | oci://<image-uri>] [--owner | --repo]", | ||
| Args: cmdutil.MinimumArgs(1, "must specify file path or container image URI, as well as one of --owner or --repo"), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| opts := &Options{} | ||
| downloadCmd := &cobra.Command{ | ||
| Use: "download [<file-path> | oci://<image-uri>] [--owner | --repo]", | ||
| Args: cmdutil.MinimumArgs(1, "must specify file path or container image URI, as well as one of --owner or --repo"), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Placeholder PR.