Skip to content

Forward codespace ports over Dev Tunnels #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmgardiner25 merged 1 commit into from
Sep 27, 2023
Merged

Forward codespace ports over Dev Tunnels #8023

dmgardiner25 merged 1 commit into from
Sep 27, 2023

Conversation

@dmgardiner25
Copy link
Contributor

@dmgardiner25 dmgardiner25 commented Sep 19, 2023 •
edited
Loading

Related: https://github.com/github/codespaces/issues/15205

Codespaces has been working towards removing our dependency on Live Share for our port forwarding and connectivity stacks. The web client has been using Dev Tunnels for port forwarding for well over a month and it has been very successful so we are moving onto the CLI to do the same.

The CLI is a bit different than our other clients because it requires the use of port forwarding for any command that doesn't send a request to the API (like gh cs ssh, gh cs rebuild, and gh cs logs just to name a few). To help make this migration go as smoothly as possible, we are going to start with only migrating the gh cs ports command as it's not as used as the gh cs ssh command (less user disruption in case of any issues) but performs more operations (add, list, and update ports) that will test the Dev Tunnels implementation (and it's been requested by users 🙂). Users shouldn't notice anything different except that the ports they forward in the CLI will now show when they connect to their codespace in the web client and will no longer show in desktop extension.

@dmgardiner25 dmgardiner25 requested review from a team as code owners September 19, 2023 21:16
@dmgardiner25 dmgardiner25 requested review from andyfeller and removed request for a team September 19, 2023 21:16
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Sep 19, 2023
samcoe
samcoe reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this work @dmgardiner25. I took a quick look over the code just to see if I spotted anything major that might need changing. I didn't spot anything, just left a couple small comments. I don't have enough of a context on implementation of codespaces to assess the logic in those areas so I mostly skipped over that for my review.

cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
cmbrose
cmbrose reviewed Sep 20, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2023
View reviewed changes
@dmgardiner25
Copy link
Contributor Author

dmgardiner25 commented Sep 25, 2023 •
edited
Loading

@samcoe Mind taking another look at this?

@dmgardiner25 dmgardiner25 force-pushed the dev-tunnels-pf branch 3 times, most recently from 073afc1 to 66fa993 Compare September 25, 2023 19:15
samcoe
samcoe suggested changes Sep 25, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 25, 2023
View reviewed changes
samcoe
samcoe approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes @dmgardiner25! I left some non-blocking comments, feel free to take or leave them 👍

@dmgardiner25 dmgardiner25 force-pushed the dev-tunnels-pf branch 2 times, most recently from 20d4b72 to 7cb35ff Compare September 27, 2023 20:39
@dmgardiner25
Copy link
Contributor Author

dmgardiner25 commented Sep 27, 2023

Made one final change to generate the private key on the fly in the mock relay server to avoid cred scanning alerts

@dmgardiner25 dmgardiner25 merged commit b4d075e into cli:trunk Sep 27, 2023
@samcoe samcoe mentioned this pull request Oct 3, 2023
Closed
renovate bot referenced this pull request in scottames/dots Oct 6, 2023
@renovate
chore(deps): update aqua (#114)
cbf7253 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[GoogleContainerTools/skaffold](https://togithub.com/GoogleContainerTools/skaffold)
| minor | `v2.7.1` -> `v2.8.0` |
| [aquaproj/aqua-registry](https://togithub.com/aquaproj/aqua-registry)
| minor | `v4.54.0` -> `v4.58.0` |
|
[bitnami-labs/sealed-secrets](https://togithub.com/bitnami-labs/sealed-secrets)
| patch | `v0.24.0` -> `v0.24.1` |
| [cli/cli](https://togithub.com/cli/cli) | minor | `v2.35.0` ->
`v2.36.0` |
| [kevincobain2000/gobrew](https://togithub.com/kevincobain2000/gobrew)
| patch | `v1.9.1` -> `1.9.3` |
| [marcosnils/bin](https://togithub.com/marcosnils/bin) | patch |
`v0.17.0` -> `v0.17.2` |
| [nektos/act](https://togithub.com/nektos/act) | patch | `v0.2.51` ->
`v0.2.52` |
| [weaveworks/eksctl](https://togithub.com/weaveworks/eksctl) | minor |
`v0.159.0` -> `v0.161.0` |

---

### Release Notes

<details>
<summary>GoogleContainerTools/skaffold
(GoogleContainerTools/skaffold)</summary>

###
[`v2.8.0`](https://togithub.com/GoogleContainerTools/skaffold/blob/HEAD/CHANGELOG.md#v280-Release---10032023)

[Compare
Source](https://togithub.com/GoogleContainerTools/skaffold/compare/v2.7.1...v2.8.0)

**Linux amd64**
`curl -Lo skaffold
https://storage.googleapis.com/skaffold/releases/v2.8.0/skaffold-linux-amd64
&& chmod +x skaffold && sudo mv skaffold /usr/local/bin`

**Linux arm64**
`curl -Lo skaffold
https://storage.googleapis.com/skaffold/releases/v2.8.0/skaffold-linux-arm64
&& chmod +x skaffold && sudo mv skaffold /usr/local/bin`

**macOS amd64**
`curl -Lo skaffold
https://storage.googleapis.com/skaffold/releases/v2.8.0/skaffold-darwin-amd64
&& chmod +x skaffold && sudo mv skaffold /usr/local/bin`

**macOS arm64**
`curl -Lo skaffold
https://storage.googleapis.com/skaffold/releases/v2.8.0/skaffold-darwin-arm64
&& chmod +x skaffold && sudo mv skaffold /usr/local/bin`

**Windows**

https://storage.googleapis.com/skaffold/releases/v2.8.0/skaffold-windows-amd64.exe

**Docker image**
`gcr.io/k8s-skaffold/skaffold:v2.8.0`

Note: This release comes with a new config version, `v4beta7`. To
upgrade your skaffold.yaml, use `skaffold fix`. If you choose not to
upgrade, skaffold will auto-upgrade as best as it can.

New Features and Additions:

- feat: Support post-renderer for helm deployer.
[#&#8203;9100](https://togithub.com/GoogleContainerTools/skaffold/pull/9100)
- feat: inject namespace from rendered manifests in post deploy hooks
[#&#8203;9090](https://togithub.com/GoogleContainerTools/skaffold/pull/9090)
- feat: Add skaffold inspect command for adding config dependencies
[#&#8203;9072](https://togithub.com/GoogleContainerTools/skaffold/pull/9072)
- feat: emit metrics for exec, verify and render
[#&#8203;9078](https://togithub.com/GoogleContainerTools/skaffold/pull/9078)
- feat: Add global build pre- and post-hooks
[#&#8203;9047](https://togithub.com/GoogleContainerTools/skaffold/pull/9047)
- feat: allow specifying a remote config dependency from Google Cloud
Storage
[#&#8203;9057](https://togithub.com/GoogleContainerTools/skaffold/pull/9057)

Updates and Refactors:

- chore: bump github/codeql-action from 2.21.8 to 2.21.9
[#&#8203;9101](https://togithub.com/GoogleContainerTools/skaffold/pull/9101)
- chore: bump github/codeql-action from 2.21.7 to 2.21.8
[#&#8203;9097](https://togithub.com/GoogleContainerTools/skaffold/pull/9097)
- chore: bump github/codeql-action from 2.21.6 to 2.21.7
[#&#8203;9096](https://togithub.com/GoogleContainerTools/skaffold/pull/9096)
- chore: add set docker host by current context
[#&#8203;9094](https://togithub.com/GoogleContainerTools/skaffold/pull/9094)
- chore: bump github/codeql-action from 2.21.5 to 2.21.6
[#&#8203;9093](https://togithub.com/GoogleContainerTools/skaffold/pull/9093)
- chore: cherry-pick upgrade ko
([#&#8203;9043](https://togithub.com/GoogleContainerTools/skaffold/issues/9043))
to v2.7
[#&#8203;9089](https://togithub.com/GoogleContainerTools/skaffold/pull/9089)
- chore: verify should preserve job manifest envs
[#&#8203;9087](https://togithub.com/GoogleContainerTools/skaffold/pull/9087)
- chore: bump actions/upload-artifact from 3.1.2 to 3.1.3
[#&#8203;9075](https://togithub.com/GoogleContainerTools/skaffold/pull/9075)
- chore: upgrade ko
[#&#8203;9043](https://togithub.com/GoogleContainerTools/skaffold/pull/9043)
- chore: bump actions/checkout from 3 to 4
[#&#8203;9067](https://togithub.com/GoogleContainerTools/skaffold/pull/9067)

Docs, Test, and Release Updates:

- docs: Fix document tutorials/skaffold-resource-selector.md
[#&#8203;9083](https://togithub.com/GoogleContainerTools/skaffold/pull/9083)
- docs: add templatable field
[#&#8203;9088](https://togithub.com/GoogleContainerTools/skaffold/pull/9088)

Huge thanks goes out to all of our contributors for this release:

-   Danilo Cianfrone
-   Matt Santa
-   Michael Plump
-   Renzo Rojas
-   Seita Uchimura
-   dependabot\[bot]
-   ericzzzzzzz
-   guangwu
-   yosukei3108

</details>

<details>
<summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary>

###
[`v4.58.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.58.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.57.0...v4.58.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.58.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.58.0)
| aquaproj/aqua-registry@v4.57.0...v4.58.0

#### 🎉 New Packages


[#&#8203;16019](https://togithub.com/aquaproj/aqua-registry/issues/16019)
[#&#8203;16027](https://togithub.com/aquaproj/aqua-registry/issues/16027)
[Boeing/config-file-validator](https://togithub.com/Boeing/config-file-validator):
Cross Platform tool to validate configuration files

[#&#8203;16025](https://togithub.com/aquaproj/aqua-registry/issues/16025)
[#&#8203;16034](https://togithub.com/aquaproj/aqua-registry/issues/16034)
[josephburnett/jd](https://togithub.com/josephburnett/jd): JSON diff and
patch

[#&#8203;16038](https://togithub.com/aquaproj/aqua-registry/issues/16038)
[#&#8203;16041](https://togithub.com/aquaproj/aqua-registry/issues/16041)
[kamadorueda/alejandra](https://togithub.com/kamadorueda/alejandra): The
Uncompromising Nix Code Formatter

[#&#8203;16024](https://togithub.com/aquaproj/aqua-registry/issues/16024)
[#&#8203;16037](https://togithub.com/aquaproj/aqua-registry/issues/16037)
[kellyjonbrazil/jc](https://togithub.com/kellyjonbrazil/jc): CLI tool
and python library that converts the output of popular command-line
tools, file-types, and common strings to JSON, YAML, or Dictionaries.
This allows piping of output to tools like jq and simplifying automation
scripts

[#&#8203;16020](https://togithub.com/aquaproj/aqua-registry/issues/16020)
[#&#8203;16040](https://togithub.com/aquaproj/aqua-registry/issues/16040)
[magodo/tfadd](https://togithub.com/magodo/tfadd): Generate valid
Terraform configuration from state

[#&#8203;16030](https://togithub.com/aquaproj/aqua-registry/issues/16030)
[orangekame3/viff](https://togithub.com/orangekame3/viff): Visual Diff
Viewer [@&#8203;ponkio-o](https://togithub.com/ponkio-o)

[#&#8203;15999](https://togithub.com/aquaproj/aqua-registry/issues/15999)
[pkgxdev/pkgx](https://togithub.com/pkgxdev/pkgx): “run anything” from
the creator of `brew`

[#&#8203;15995](https://togithub.com/aquaproj/aqua-registry/issues/15995)
[sorenisanerd/gotty](https://togithub.com/sorenisanerd/gotty): Share
your terminal as a web application

[#&#8203;16002](https://togithub.com/aquaproj/aqua-registry/issues/16002)
[xataio/pgroll](https://togithub.com/xataio/pgroll): Postgres
zero-downtime migrations made easy

#### Fixes


[#&#8203;15996](https://togithub.com/aquaproj/aqua-registry/issues/15996)
awslabs/amazon-ecr-credential-helper: Add checksum and enable rosetta2
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

###
[`v4.57.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.57.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.56.0...v4.57.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.57.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.57.0)
| aquaproj/aqua-registry@v4.56.0...v4.57.0

#### 🎉 New Packages


[#&#8203;15963](https://togithub.com/aquaproj/aqua-registry/issues/15963)
[#&#8203;15988](https://togithub.com/aquaproj/aqua-registry/issues/15988)
[hashicorp/terraform-config-inspect](https://togithub.com/hashicorp/terraform-config-inspect):
A helper library for shallow inspection of Terraform configurations

[#&#8203;15965](https://togithub.com/aquaproj/aqua-registry/issues/15965)
[#&#8203;15992](https://togithub.com/aquaproj/aqua-registry/issues/15992)
[magodo/hclgrep](https://togithub.com/magodo/hclgrep): Syntax based grep
for HCL(v2)

[#&#8203;15966](https://togithub.com/aquaproj/aqua-registry/issues/15966)
[#&#8203;15989](https://togithub.com/aquaproj/aqua-registry/issues/15989)
[pcasteran/terraform-graph-beautifier](https://togithub.com/pcasteran/terraform-graph-beautifier):
Terraform graph beautifier

[#&#8203;15964](https://togithub.com/aquaproj/aqua-registry/issues/15964)
[#&#8203;15991](https://togithub.com/aquaproj/aqua-registry/issues/15991)
[rgreinho/tfe-cli](https://togithub.com/rgreinho/tfe-cli): CLI client
for Terraform enterprise

###
[`v4.56.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.56.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.55.0...v4.56.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.56.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.56.0)
| aquaproj/aqua-registry@v4.55.0...v4.56.0

#### 🎉 New Packages


[#&#8203;15932](https://togithub.com/aquaproj/aqua-registry/issues/15932)
[cbroglie/mustache](https://togithub.com/cbroglie/mustache): The
mustache template language in Go

[#&#8203;15955](https://togithub.com/aquaproj/aqua-registry/issues/15955)
[k1LoW/gostyle](https://togithub.com/k1LoW/gostyle): gostyle is a set of
analyzers for coding styles
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

#### Fixes


[#&#8203;15918](https://togithub.com/aquaproj/aqua-registry/issues/15918)
marcosnils/bin: Follow up changes of bin v0.17.1

-
marcosnils/bin@4aaa173
-   https://github.com/marcosnils/bin/releases/tag/v0.17.1


[#&#8203;15933](https://togithub.com/aquaproj/aqua-registry/issues/15933)
marcosnils/bin: Follow up changes of bin v0.17.2

-   https://github.com/marcosnils/bin/releases/tag/v0.17.2
-
marcosnils/bin@f7265c4

###
[`v4.55.0`](https://togithub.com/aquaproj/aqua-registry/releases/tag/v4.55.0)

[Compare
Source](https://togithub.com/aquaproj/aqua-registry/compare/v4.54.0...v4.55.0)


[Issues](https://togithub.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.55.0)
| [Pull
Requests](https://togithub.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.55.0)
| aquaproj/aqua-registry@v4.54.0...v4.55.0

#### 🎉 New Packages


[#&#8203;15883](https://togithub.com/aquaproj/aqua-registry/issues/15883)
[k1LoW/stubin](https://togithub.com/k1LoW/stubin): This is stub binary
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

[#&#8203;15882](https://togithub.com/aquaproj/aqua-registry/issues/15882)
[mashiike/prepalert](https://togithub.com/mashiike/prepalert): Toil
reduction tool to prepare before responding to Mackerel alerts
[@&#8203;ponkio-o](https://togithub.com/ponkio-o)

#### Fixes


[#&#8203;15813](https://togithub.com/aquaproj/aqua-registry/issues/15813)
hashicorp/copywrite: Follow up changes of copywrite v0.16.6

-   https://github.com/hashicorp/copywrite/releases/tag/v0.16.6
-
[https://github.com/hashicorp/copywrite/pull/99](https://togithub.com/hashicorp/copywrite/pull/99)

</details>

<details>
<summary>bitnami-labs/sealed-secrets
(bitnami-labs/sealed-secrets)</summary>

###
[`v0.24.1`](https://togithub.com/bitnami-labs/sealed-secrets/blob/HEAD/RELEASE-NOTES.md#v0241)

[Compare
Source](https://togithub.com/bitnami-labs/sealed-secrets/compare/v0.24.0...v0.24.1)

##### Changelog

- fix: remove trailing dashes for multidoc yaml
([#&#8203;1335](https://togithub.com/bitnami-labs/sealed-secrets/pull/1335))

</details>

<details>
<summary>cli/cli (cli/cli)</summary>

### [`v2.36.0`](https://togithub.com/cli/cli/releases/tag/v2.36.0):
GitHub CLI 2.36.0

[Compare Source](https://togithub.com/cli/cli/compare/v2.35.0...v2.36.0)

#### What's Changed

- `codespace`: Hint adding `codespace` scope when not logged in by
[@&#8203;rajhawaldar](https://togithub.com/rajhawaldar) in
[https://github.com/cli/cli/pull/7961](https://togithub.com/cli/cli/pull/7961)
- `codespace ports`: Forward codespace ports over Dev Tunnels by
[@&#8203;dmgardiner25](https://togithub.com/dmgardiner25) in
[https://github.com/cli/cli/pull/8023](https://togithub.com/cli/cli/pull/8023)
- `cache delete`: Percent-encode keys by
[@&#8203;benoit-pierre](https://togithub.com/benoit-pierre) in
[https://github.com/cli/cli/pull/8030](https://togithub.com/cli/cli/pull/8030)
- `gpg-key delete`, `run watch`: Return HTTP errors properly by
[@&#8203;heaths](https://togithub.com/heaths) in
[https://github.com/cli/cli/pull/8037](https://togithub.com/cli/cli/pull/8037)
- `pr checks`: Show cancelled checks by
[@&#8203;rajhawaldar](https://togithub.com/rajhawaldar) in
[https://github.com/cli/cli/pull/7960](https://togithub.com/cli/cli/pull/7960)
- `cache list`: Add JSON exporting support by
[@&#8203;siketyan](https://togithub.com/siketyan) in
[https://github.com/cli/cli/pull/7954](https://togithub.com/cli/cli/pull/7954)
- `auth`: Fix startup panic when logged out by
[@&#8203;alrs](https://togithub.com/alrs) in
[https://github.com/cli/cli/pull/8105](https://togithub.com/cli/cli/pull/8105)
- `secret list`, `deploy-key list`: Support standard output format flags
by [@&#8203;rajhawaldar](https://togithub.com/rajhawaldar) in
[https://github.com/cli/cli/pull/8081](https://togithub.com/cli/cli/pull/8081)
- `pr create`: Update the docs on flag `--fill` by
[@&#8203;peterramaldes](https://togithub.com/peterramaldes) in
[https://github.com/cli/cli/pull/8080](https://togithub.com/cli/cli/pull/8080)
- `run view`: Use attempt input when fetching jobs by
[@&#8203;arunsathiya](https://togithub.com/arunsathiya) in
[https://github.com/cli/cli/pull/7831](https://togithub.com/cli/cli/pull/7831)
- `project item-edit`: New clear flag to remove item field value by
[@&#8203;arunsathiya](https://togithub.com/arunsathiya) in
[https://github.com/cli/cli/pull/8024](https://togithub.com/cli/cli/pull/8024)
- build(deps): Bump mislav/bump-homebrew-formula-action from 2 to 3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/cli/cli/pull/8033](https://togithub.com/cli/cli/pull/8033)
- Update triage documentation with link to unlabeled open issues by
[@&#8203;andyfeller](https://togithub.com/andyfeller) in
[https://github.com/cli/cli/pull/8082](https://togithub.com/cli/cli/pull/8082)

#### New Contributors

- [@&#8203;benoit-pierre](https://togithub.com/benoit-pierre) made their
first contribution in
[https://github.com/cli/cli/pull/8030](https://togithub.com/cli/cli/pull/8030)
- [@&#8203;siketyan](https://togithub.com/siketyan) made their first
contribution in
[https://github.com/cli/cli/pull/7954](https://togithub.com/cli/cli/pull/7954)
- [@&#8203;alrs](https://togithub.com/alrs) made their first
contribution in
[https://github.com/cli/cli/pull/8105](https://togithub.com/cli/cli/pull/8105)
- [@&#8203;peterramaldes](https://togithub.com/peterramaldes) made their
first contribution in
[https://github.com/cli/cli/pull/8080](https://togithub.com/cli/cli/pull/8080)
- [@&#8203;arunsathiya](https://togithub.com/arunsathiya) made their
first contribution in
[https://github.com/cli/cli/pull/7831](https://togithub.com/cli/cli/pull/7831)

**Full Changelog**: cli/cli@v2.35.0...v2.36.0

</details>

<details>
<summary>kevincobain2000/gobrew (kevincobain2000/gobrew)</summary>

###
[`v1.9.3`](https://togithub.com/kevincobain2000/gobrew/releases/tag/1.9.3)

[Compare
Source](https://togithub.com/kevincobain2000/gobrew/compare/v1.9.2...1.9.3)

#### Changelog

-
[`987f799`](https://togithub.com/kevincobain2000/gobrew/commit/987f799)
Merge pull request
[#&#8203;142](https://togithub.com/kevincobain2000/gobrew/issues/142)
from kevincobain2000/bug141
-
[`9f2309b`](https://togithub.com/kevincobain2000/gobrew/commit/9f2309b)
fix: process errors on doRequest with exit

###
[`v1.9.2`](https://togithub.com/kevincobain2000/gobrew/releases/tag/v1.9.2)

[Compare
Source](https://togithub.com/kevincobain2000/gobrew/compare/v1.9.1...v1.9.2)

#### Changelog

-
[`b426d86`](https://togithub.com/kevincobain2000/gobrew/commit/b426d86)
(ci) coveritup add time taken by unit tests
-
[`af2d6ab`](https://togithub.com/kevincobain2000/gobrew/commit/af2d6ab)
Merge pull request
[#&#8203;133](https://togithub.com/kevincobain2000/gobrew/issues/133)
from kevincobain2000/feature/ci
-
[`56a6b97`](https://togithub.com/kevincobain2000/gobrew/commit/56a6b97)
Merge pull request
[#&#8203;134](https://togithub.com/kevincobain2000/gobrew/issues/134)
from kevincobain2000/feature/ci
-
[`f410516`](https://togithub.com/kevincobain2000/gobrew/commit/f410516)
Merge pull request
[#&#8203;140](https://togithub.com/kevincobain2000/gobrew/issues/140)
from kevincobain2000/bug/139
-
[`6bfcb8f`](https://togithub.com/kevincobain2000/gobrew/commit/6bfcb8f)
feat: remove Sprintf from color.Errorln
-
[`2353cdb`](https://togithub.com/kevincobain2000/gobrew/commit/2353cdb)
feat: simplifying the use of the github api
-
[`13a1857`](https://togithub.com/kevincobain2000/gobrew/commit/13a1857)
fix: processing invalid GITHUB_TOKEN
-
[`b2ca852`](https://togithub.com/kevincobain2000/gobrew/commit/b2ca852)
purge badges

</details>

<details>
<summary>marcosnils/bin (marcosnils/bin)</summary>

###
[`v0.17.2`](https://togithub.com/marcosnils/bin/releases/tag/v0.17.2)

[Compare
Source](https://togithub.com/marcosnils/bin/compare/v0.17.1...v0.17.2)

#### Changelog

- [`f7265c4`](https://togithub.com/marcosnils/bin/commit/f7265c4) ci:
bring back archives format

###
[`v0.17.1`](https://togithub.com/marcosnils/bin/releases/tag/v0.17.1)

[Compare
Source](https://togithub.com/marcosnils/bin/compare/v0.17.0...v0.17.1)

#### Changelog

- [`10be63c`](https://togithub.com/marcosnils/bin/commit/10be63c) add
support GITHUB_TOKEN env var
([#&#8203;176](https://togithub.com/marcosnils/bin/issues/176))
- [`eb65e2d`](https://togithub.com/marcosnils/bin/commit/eb65e2d) feat:
Bump Go version to 1.20
([#&#8203;169](https://togithub.com/marcosnils/bin/issues/169))
- [`f715904`](https://togithub.com/marcosnils/bin/commit/f715904) feat:
Detect Go version in the pipeline
([#&#8203;175](https://togithub.com/marcosnils/bin/issues/175))
- [`4aaa173`](https://togithub.com/marcosnils/bin/commit/4aaa173) remove
depracated goreleaser config

</details>

<details>
<summary>nektos/act (nektos/act)</summary>

### [`v0.2.52`](https://togithub.com/nektos/act/releases/tag/v0.2.52)

[Compare
Source](https://togithub.com/nektos/act/compare/v0.2.51...v0.2.52)

#### Changelog

##### Other

- [`44ea01c`](https://togithub.com/nektos/act/commit/44ea01c) chore:
bump VERSION to 0.2.52
- [`2be4def`](https://togithub.com/nektos/act/commit/2be4def)
build(deps): bump github.com/rhysd/actionlint from 1.6.25 to 1.6.26
([#&#8203;2026](https://togithub.com/nektos/act/issues/2026))
- [`3d47885`](https://togithub.com/nektos/act/commit/3d47885)
build(deps): bump megalinter/megalinter from 7.3.0 to 7.4.0
([#&#8203;2025](https://togithub.com/nektos/act/issues/2025))

</details>

<details>
<summary>weaveworks/eksctl (weaveworks/eksctl)</summary>

###
[`v0.161.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.161.0):
eksctl 0.161.0 (permalink)

[Compare
Source](https://togithub.com/weaveworks/eksctl/compare/0.160.0-rc.0...0.161.0-rc.0)

### Release v0.161.0

#### 🚀 Features

- Make EKS 1.27 default
([#&#8203;7117](https://togithub.com/weaveworks/eksctl/issues/7117))
- Docs Landing page
([#&#8203;7092](https://togithub.com/weaveworks/eksctl/issues/7092))

#### 🎯 Improvements

- Refine log statements using `%w` for better formatting and UX
([#&#8203;7115](https://togithub.com/weaveworks/eksctl/issues/7115))

#### 🧰 Maintenance

- Update gomarkdown to fix out-of-bounds read while parsing citations
([#&#8203;7120](https://togithub.com/weaveworks/eksctl/issues/7120))
- Upgrade go-restful
([#&#8203;7121](https://togithub.com/weaveworks/eksctl/issues/7121))
- Move addons related tasks to actions package
([#&#8203;7077](https://togithub.com/weaveworks/eksctl/issues/7077))

###
[`v0.160.0`](https://togithub.com/eksctl-io/eksctl/releases/tag/v0.160.0):
eksctl 0.160.0 (permalink)

[Compare
Source](https://togithub.com/weaveworks/eksctl/compare/0.159.0-rc.0...0.160.0-rc.0)

### Release v0.160.0

#### 🚀 Features

- Add support for EKS 1.28
([#&#8203;7108](https://togithub.com/weaveworks/eksctl/issues/7108))

#### 🧰 Maintenance

- Bump dependencies
([#&#8203;7109](https://togithub.com/weaveworks/eksctl/issues/7109))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on thursday" in timezone
America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dmgardiner25 dmgardiner25 mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmbrose cmbrose cmbrose approved these changes

@andyfeller andyfeller Awaiting requested review from andyfeller andyfeller is a code owner automatically assigned from cli/code-reviewers

+1 more reviewer

@samcoe samcoe samcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmgardiner25 @cmbrose @samcoe @cliAutomation